Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EM calculation bug #2395

Open
neilriley-NOAA opened this issue Jul 14, 2021 · 3 comments
Open

EM calculation bug #2395

neilriley-NOAA opened this issue Jul 14, 2021 · 3 comments
Assignees
Labels
bug Something isn't working Prj: EM Project: Electronic Monitoring

Comments

@neilriley-NOAA
Copy link

@sethgerou-noaa there is a bug in the calculation code

image

Example trip is 100322 in Dev: I submitted a discard for a single sablefish length (50 cm) which returned a weight of 1 lb. The weight should be 2.64 lbs. I think the error is with the β. appears the Beta value is being multiplied instead of being raised to the power.

Sablefish
α = 0.000003927
β = 3.430072

image

@neilriley-NOAA neilriley-NOAA added Prj: EM Project: Electronic Monitoring bug Something isn't working labels Jul 14, 2021
@neilriley-NOAA neilriley-NOAA added this to To do in Electronic Monitoring via automation Jul 14, 2021
@neilriley-NOAA neilriley-NOAA changed the title EM calculationn bug EM calculation bug Jul 15, 2021
@neilriley-NOAA
Copy link
Author

submitted review data for trip 100322 in dev. the review data is not displaying on the comparison or the em review page.

@neilriley-NOAA
Copy link
Author

@sethgerou-noaa for trip 100325 I calculated a different value than what is displayed in the EM results table for sablefish. Below is the json of the catch record. I calculate a 2.64 lbs for a single fish at 50 cm. The EM results page is displaying 4 lbs. Not sure where the bug is?

    {
      "disposition": "Discarded",
      "speciesCode": "SABL",
      "speciesLength": 50,
      "speciesCount": 1,
      "calcWeightType": "Estimated Weight",
      "comments": "Count greater than 1 for a length"

@melinashak-noaa
Copy link
Contributor

melinashak-noaa commented Aug 1, 2021

This was caused by the missing weight expansion pulling all catch data, even that in the revision history. So fixed it to just pull just the current catch and now it's calculating correctly. Getting 2.64 now.

Just a note, @neilriley-NOAA the discard mortality rate rule is also being applied to trip 100325 since catch is sablefish and gear used is pot. So speciesWeight = 2.64 * .2 = .528 since 20% mortality is taken . When I change gear to longline (snap) getting 2.64 though.

Electronic Monitoring automation moved this from To do to Done Aug 3, 2021
Electronic Monitoring automation moved this from Done to In progress Aug 3, 2021
@melinashak-noaa melinashak-noaa moved this from In progress to review changes in Electronic Monitoring Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Prj: EM Project: Electronic Monitoring
Projects
Electronic Monitoring
  
review changes
Development

No branches or pull requests

3 participants