virtio_pci_cap64: specify offset_hi, length_hi endianness
#196
Labels
Comments
|
consistent with 32 bit cap |
|
BALLOT CREATED AT URL: https://groups.oasis-open.org/higherlogic/ws/public/ballot?id=3841 |
paravmellanox
pushed a commit
to paravmellanox/virtio-spec
that referenced
this issue
Jul 9, 2024
While the capability introduction says "This virtio structure capability uses little-endian format," it might be preferrable to be explicit about the endianness of offset_hi and length_hi. Signed-off-by: Martin Kröning <[email protected]> Reviewed-by: Parav Pandit <[email protected]> Fixes: oasis-tcs#196
paravmellanox
pushed a commit
to paravmellanox/virtio-spec
that referenced
this issue
Jul 11, 2024
While the capability introduction says "This virtio structure capability uses little-endian format," it might be preferrable to be explicit about the endianness of offset_hi and length_hi. Signed-off-by: Martin Kröning <[email protected]> Reviewed-by: Parav Pandit <[email protected]> Fixes: oasis-tcs#196
paravmellanox
pushed a commit
to paravmellanox/virtio-spec
that referenced
this issue
Jul 11, 2024
While the capability introduction says "This virtio structure capability uses little-endian format," it might be preferrable to be explicit about the endianness of offset_hi and length_hi. Signed-off-by: Martin Kröning <[email protected]> Reviewed-by: Parav Pandit <[email protected]> Fixes: oasis-tcs#196
paravmellanox
pushed a commit
to paravmellanox/virtio-spec
that referenced
this issue
Jul 11, 2024
While the capability introduction says "This virtio structure capability uses little-endian format," it might be preferrable to be explicit about the endianness of offset_hi and length_hi. Signed-off-by: Martin Kröning <[email protected]> Reviewed-by: Parav Pandit <[email protected]> Fixes: oasis-tcs#196 Message-Id: <[email protected]>
mstsirkin
pushed a commit
that referenced
this issue
Jul 11, 2024
While the capability introduction says "This virtio structure capability uses little-endian format," it might be preferrable to be explicit about the endianness of offset_hi and length_hi. Signed-off-by: Martin Kröning <[email protected]> Reviewed-by: Parav Pandit <[email protected]> Fixes: #196 Message-Id: <[email protected]>
mstsirkin
pushed a commit
that referenced
this issue
Jul 11, 2024
While the capability introduction says "This virtio structure capability uses little-endian format," it might be preferrable to be explicit about the endianness of offset_hi and length_hi. Signed-off-by: Martin Kröning <[email protected]> Reviewed-by: Parav Pandit <[email protected]> Fixes: #196 Message-Id: <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
mstsirkin
pushed a commit
that referenced
this issue
Jul 12, 2024
While the capability introduction says "This virtio structure capability uses little-endian format," it might be preferrable to be explicit about the endianness of offset_hi and length_hi. Signed-off-by: Martin Kröning <[email protected]> Reviewed-by: Parav Pandit <[email protected]> Fixes: #196 Message-Id: <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should be explicit about the endianness of
offset_hiandlength_hiinvirtio_pci_cap64.Proposal: https://lore.kernel.org/virtio-comment/PH0PR12MB5481A6C266BD5303B98AF5EEDCC72@PH0PR12MB5481.namprd12.prod.outlook.com/T/#m6d45232211d1e1b617171189515a5e11c9b7642c
The text was updated successfully, but these errors were encountered: