Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Use import instead of create to open Ledger account #5

Open
matevz opened this issue Apr 22, 2022 · 0 comments
Open

cli: Use import instead of create to open Ledger account #5

matevz opened this issue Apr 22, 2022 · 0 comments
Labels
ui Improve user experience

Comments

@matevz
Copy link
Member

matevz commented Apr 22, 2022

Term "create" should be used if the CLI generates a new keypair. When adding a Ledger account into the wallet, CLI doesn't generate or overwrite anything, but just registers existing Ledger account to the CLI.

Use oasis wallet import to add the Ledger account instead of oasis wallet create. In this case importing would also be done interactively so the user can see the Ledger option and easily provide the key derivation index (no need for non-obvious --kind ledger and --number x flags). This also makes the CLI flow consistent with Oasis wallet web and extension.

@tjanez tjanez transferred this issue from oasisprotocol/oasis-sdk Jan 4, 2023
@tjanez tjanez added the ui Improve user experience label Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Improve user experience
Projects
None yet
Development

No branches or pull requests

2 participants