Don't show TX error messages for empty error blocks

[csillag]

Some transactions have an error block like this:

"error": {
  "code": 0,
  "module": ""
}

An example found by @matevz is available here.

In these cases, no error message should be shown.

[github-actions]

Deployed to Cloudflare Pages

Latest commit:	f7c66a24f729822878194e6292196b13a2d91eec
Status:	✅ Deploy successful!
Preview URL:	https://86772af1.oasis-explorer.pages.dev

[csillag]

This is marked as draft until someone can verify that my interpretation of the situation is correct.

[csillag]

This is marked as draft until someone can verify that my interpretation of the situation is correct.

Yes: @kostko says that

Yes code 0 is always success.

So, we don't have to show an error message here.

[lubej]

Why check for a module? I think simplification should suffice:

Suggested change

	if (!error || (!error.module && !error.code)) return undefined
	if (!error?.code) return undefined

[csillag]

Why check for a module?

Because I don't know if we can assume that all possible modules (i.e. sources of errors) are sane enough to use the 0 error code for success.

There might be some deranged modules that break the convention.

Generally speaking, when hiding error messages, I want to be as narrow and specific as possible. We know that no module and error code 0 is not a problem, so we can hide this, but nothing else.

If we see more useless error messages later, we can also hide them later...

[lubej]

Maybe add a TODO, if this ever gets resolved upstream.

[lukaw3d]

Frontend should not be fixing this

[lubej]

Frontend should not be fixing this

How about we create an issue upstream?
And merge this quick fix for now. As it takes "ages" to propagate the change on the BE side to mainnet.

[csillag]

How about we create an issue upstream?

The discussion with the Nexus guys have been going on for 3 days now.

And merge this quick fix for now.

I agree, but waiting for @lukaw3d's decision.

As it takes "ages" to propagate the change on the BE side to mainnet.

Exactly.

[lukaw3d]

🤷 seems very rare, and frontend can't correctly fix the transaction anyway: method missing, and status missing

[csillag]

Not much progress with the Nexus issue for the last 3 weeks. I still thing we ought to merge the frontend workaround, at least in order to remove the spurious error message...