Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DcsWithRuntime is thread-unsafe #3122

Closed
levBagryansky opened this issue Apr 19, 2024 · 2 comments · Fixed by #3123
Closed

DcsWithRuntime is thread-unsafe #3122

levBagryansky opened this issue Apr 19, 2024 · 2 comments · Fixed by #3123
Assignees

Comments

@levBagryansky
Copy link
Member

DcsWithRuntime is thread-unsafe since it has private static final Unchecked<Dependency> MAVEN_DEPENDENCY = DcsWithRuntime.mavenDependency() which is Sticky (thread-unsafe) inside.

levBagryansky added a commit to levBagryansky/eo that referenced this issue Apr 19, 2024
Copy link

@levBagryansky thanks for the report, here is a feedback:

Problems

  • Lack of Detail: The report only mentions that 'DcsWithRuntime' is thread-unsafe without any further explanation or context. There is no clarification on why this is problematic or under which circumstances this could lead to complications.
  • No Steps to Reproduce: The report fails to provide any steps that could potentially reproduce the issue. This component is essential in any bug report as it allows developers to comprehend the precise conditions that lead to the occurrence of the bug.
  • Missing Expected versus Actual Result: The report does not specify what the expected outcome should be as opposed to the ongoing, problematic behavior. Absence of this information makes it challenging to measure the seriousness of the problem and to come up with suitable solutions.

Suggestions

  • Provide Detailed Description: Expand the description of the problem. Explain why 'DcsWithRuntime' being thread-unsafe is an issue. This could include the impact on the system, the potential risks, and any errors or issues that this might cause.
  • Add Steps to Reproduce: Include detailed steps to reproduce the issue. This should be a clear, step-by-step guide that any developer can follow to see the issue firsthand. It can also be beneficial to include the specific conditions under which the bug occurs.
  • Expected versus Actual Result: Clearly state what the expected result or behavior should be in the given situation and contrast this with what is currently happening (the actual result). This will give a clear indication of what the problem is and how the system is deviating from the expected behavior.
  • Provide Context: If applicable, provide context about how the 'DcsWithRuntime' is used within the system and how it interacts with other components. This could provide clues as to why the issue is occurring.
  • Include Error Messages or Logs: If there are any error messages or logs related to 'DcsWithRuntime' being thread-unsafe, include them in the report. This can provide important clues for diagnosing the problem.

Please fix the bug report in order it to get resolved faster.
Analyzed with gpt-4

@0pdd
Copy link

0pdd commented May 2, 2024

@levBagryansky the puzzle #3158 is still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants