406 support enabling/disabling particular atoms #426

deemp · 2024-07-01T18:16:29Z

Issues

PR-Codex overview

This PR updates the eo-phi-normalizer package by adding new phi files, updating pipeline configurations, and introducing new rules.

Detailed summary

Added new phi files for error, dataized, cti, try, rust, string, cage, true, false, nan, go, and while
Updated pipeline configurations and hashes
Modified TH.hs, Config.hs, RunYegor.hs, Fast.hs
Introduced new rules and functions in various files

The following files were skipped due to too many changes: eo-phi-normalizer/data/0.38.4/org/eolang/while.phi, eo-phi-normalizer/data/0.38.4/org/eolang/seq.phi, eo-phi-normalizer/data/0.38.4/org/eolang/int.phi, eo-phi-normalizer/data/0.38.4/org/eolang/switch.phi, eo-phi-normalizer/src/Language/EO/Phi/Pipeline/Dataize/PrintConfigs.hs, eo-phi-normalizer/data/0.38.4/org/eolang/malloc.phi, eo-phi-normalizer/data/0.38.4/org/eolang/bytes.phi, eo-phi-normalizer/src/Language/EO/Phi/Rules/Common.hs, eo-phi-normalizer/data/0.38.4/org/eolang/tuple.phi, eo-phi-normalizer/data/0.38.4/org/eolang/float.phi, site/docs/src/pipeline.md, scripts/pipeline.sh, eo-phi-normalizer/data/0.38.4/org/eolang/positive-infinity.phi, eo-phi-normalizer/data/0.38.4/org/eolang/negative-infinity.phi, eo-phi-normalizer/eo-phi-normalizer.cabal, eo-phi-normalizer/app/Main.hs, eo-phi-normalizer/src/Language/EO/Phi/Dataize.hs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

fizruk · 2024-07-05T05:07:17Z

eo-phi-normalizer/src/Language/EO/Phi/Dataize.hs

-      fail (name <> ": Couldn't find bytes in RHS: " <> printTree (hideRho r))
-  return (result, ())
+  ctx <- getContext
+  if HashSet.member (DisabledAtomName name) ctx.disabledAtomNames


This is not the correct place for this check. Instead, use the check in the dataizeStepChain function, before evaluateBuiltinFunChain is called.

- calculate and store in the dataization context only enabled atoms

- move existing command for preparing tests into the 'pipeline' command - add command for printing 'normalizer dataize' configs into the 'pipeline' command

0crat · 2024-07-06T22:21:07Z

@fizruk Thanks for the review! You've earned +25 points for this.

deemp · 2024-07-10T13:47:31Z

To enable or disable particular atoms for a pipeline test set, add an atoms object into the test set in the pipeline config (the file path is pipeline/config.yaml).

If you enable particular atoms, only these atoms are enabled.
If you don't enable particular atoms, all atoms except disabled are enabled.

Here's an example of a test set where the foo atom is enabled and the bar atom is disabled.
Note that the Package atom is disabled.

- eo:
    original: eo/eo-runtime/src/test/eo/org/eolang/as-phi-tests.eo
    yaml: pipeline/eo-yaml/as-phi-tests.yaml
    filtered: pipeline/eo-filtered/as-phi-tests.eo
  phi:
    initial: pipeline/phi-initial/as-phi-tests.phi
    normalized: pipeline/phi-normalized/as-phi-tests.phi
    bindings-path-initial: org.eolang
    bindings-path-normalized: org.eolang
  atoms:
    enable:
      - foo
    disable:
      - bar

fizruk · 2024-07-17T16:19:35Z

eo-phi-normalizer/src/Language/EO/Phi/Dataize.hs

-          ctx <- getContext
-          return (ctx, Left obj')
+      ctx' <- getContext
+      if HashSet.member funcName knownAtomNames && not (HashSet.member funcName ctx'.enabledAtomNames)


I would factor this condition into a separate function.

Addressed in 32be6c9

However, I'm not sure I understood your suggestion correctly.

fizruk · 2024-07-17T16:20:37Z

eo-phi-normalizer/src/Language/EO/Phi/Dataize.hs

@@ -270,87 +278,129 @@ evaluateBytesBytesFunChain name = evaluateUnaryDataizationFunChain name intToByt
 evaluateFloatFloatFloatFunChain :: String -> (Double -> Double -> Double) -> Object -> EvaluationState -> DataizeChain (Object, EvaluationState)
 evaluateFloatFloatFloatFunChain name = evaluateBinaryDataizationFunChain name floatToBytes bytesToFloat wrapBytesInFloat extractRho (extractLabel "x")

+knownAtoms :: [(String, String -> Object -> EvaluationState -> DataizeChain (Object, EvaluationState))]
+knownAtoms =
+  [ ("Lorg_eolang_int_gt", \name obj -> evaluateIntIntBoolFunChain name (>) obj)


If you change the order of arguments, you can avoid lambdas and simply write evaluateIntIntBoolFunChain (>).

Addressed in 9653b2e

fizruk · 2024-07-17T16:21:46Z

eo-phi-normalizer/src/Language/EO/Phi/Dataize.hs

+
+evaluateBuiltinFunChainUnknown :: String -> a -> b1 -> Chain (Either a b2) (a, b1)
+evaluateBuiltinFunChainUnknown atomName obj state = do
+  logStep [fmt|[WARNING]: unknown atom ({atomName})|] (Left obj)


Unknown atoms are normal and should not be warnings.

Addressed in 75fb769

0crat · 2024-07-19T09:16:38Z

@deemp Thanks for the contribution! You've earned +5 points for this: +20 as a basis; +5 for 2236 hits-of-code; -7 for too many hits-of-code (2236 >= 100); -15 for way too many hits-of-code (2236 >= 400); -9 for 9 comments; +11 to give you at least something. Please, keep them coming.

deemp added 2 commits July 1, 2024 14:03

feat(normalizer): add dependencies

876233c

feat(normalizer): support disabling particular atoms

726d9b9

deemp linked an issue Jul 1, 2024 that may be closed by this pull request

Support enabling/disabling particular atoms #406

Closed

6 tasks

deemp requested a review from fizruk July 1, 2024 18:16

fizruk reviewed Jul 5, 2024

View reviewed changes

deemp added 10 commits July 5, 2024 18:37

fix(normalizer): disallow missing fields in configs

75ddd6e

feat(normalizer): allow configuring atoms in pipeline config

9db42de

feat(normalizer): print configs for dataization in pipeline

206efa1

fix(normalizer): logic for enabling/disabling atoms

c9a8713

- calculate and store in the dataization context only enabled atoms

fix(normalizer): move filtering lambdas to another function

d42f8f8

feat(normalizer): add 'pipeline' commands

d6df7aa

- move existing command for preparing tests into the 'pipeline' command - add command for printing 'normalizer dataize' configs into the 'pipeline' command

fix(scripts): use the new 'normalizer pipeline' command

77a001a

feat(scripts): enable -x flag

d14f000

feat(scripts): add variable

7d4ca89

fix(normalizer): update import to make fourmolu happy

7134c09

deemp and others added 11 commits July 10, 2024 14:13

chore(normalizer): update .cabal

3858c86

chore(eo): bump 0.38.3 -> 0.38.4

24beb65

fix(normalizer): use known atoms instead of supported

310215f

fix(pipeline): use eval to construct an array

1825c95

feat(normalizer): support printing dataize configs on a single line

1bbee65

fix(pipeline): file paths

eaae945

feat(normalizer): print whether a test set is enabled

4fc506b

feat(pipeline): run only enabled test sets

f12dd92

fix(pipeline): temporarily disable seq-tests because normalizer hangs

3238e9a

Update pipeline/pipeline.lock

2638035

Update normalizer data files

29a5ba4

deemp added 2 commits July 10, 2024 17:01

fix(normalizer): not evaluate only known and disabled atoms

f4b199a

refactor(normalizer): make fourmolu happy

bd0df2d

fizruk changed the title ~~406 support enablingdisabling particular atoms~~ 406 support enabling/disabling particular atoms Jul 11, 2024

fizruk approved these changes Jul 11, 2024

View reviewed changes

deemp added 3 commits July 11, 2024 18:28

refactor(normalizer): use a map with function parameters

7d66b9a

refactor(normalizer): move defaultContext

a592d2e

fix(normalizer): make fourmolu happy

ffe4119

deemp force-pushed the 406-support-enablingdisabling-particular-atoms branch from eb93f5b to ffe4119 Compare July 11, 2024 16:53

deemp mentioned this pull request Jul 11, 2024

Update eo to 0.38.4 #431

Closed

2 tasks

deemp added 4 commits July 12, 2024 13:46

refactor(site): improve wording

0644182

feat(site): document 'atoms' object

5415f71

feat(site): add docs for the normalizer pipeline command

064fbb0

fix(site): header level

89cac90

deemp requested a review from fizruk July 16, 2024 11:34

fizruk reviewed Jul 17, 2024

View reviewed changes

deemp added 3 commits July 17, 2024 19:56

refactor(normalizer): use pointfree calls

9653b2e

fix(normalizer): don't warn on unknown atoms

75fb769

refactor(normalizer): factor out the condition into a function

32be6c9

deemp requested a review from fizruk July 17, 2024 22:13

fizruk approved these changes Jul 19, 2024

View reviewed changes

fizruk merged commit c2ce147 into master Jul 19, 2024
8 checks passed

fizruk deleted the 406-support-enablingdisabling-particular-atoms branch July 19, 2024 03:43

deemp mentioned this pull request Jul 19, 2024

chore(eo): bump version 0.38.0 -> 0.38.3 #398

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

406 support enabling/disabling particular atoms #426

406 support enabling/disabling particular atoms #426

deemp commented Jul 1, 2024 •

edited by pr-codex bot

Loading

fizruk Jul 5, 2024

0crat commented Jul 6, 2024

deemp commented Jul 10, 2024 •

edited

Loading

fizruk Jul 17, 2024

deemp Jul 17, 2024

fizruk Jul 17, 2024

deemp Jul 17, 2024 •

edited

Loading

fizruk Jul 17, 2024

deemp Jul 17, 2024

0crat commented Jul 19, 2024

406 support enabling/disabling particular atoms #426

406 support enabling/disabling particular atoms #426

Conversation

deemp commented Jul 1, 2024 • edited by pr-codex bot Loading

Issues

PR-Codex overview

Detailed summary

fizruk Jul 5, 2024

Choose a reason for hiding this comment

0crat commented Jul 6, 2024

deemp commented Jul 10, 2024 • edited Loading

fizruk Jul 17, 2024

Choose a reason for hiding this comment

deemp Jul 17, 2024

Choose a reason for hiding this comment

fizruk Jul 17, 2024

Choose a reason for hiding this comment

deemp Jul 17, 2024 • edited Loading

Choose a reason for hiding this comment

fizruk Jul 17, 2024

Choose a reason for hiding this comment

deemp Jul 17, 2024

Choose a reason for hiding this comment

0crat commented Jul 19, 2024

deemp commented Jul 1, 2024 •

edited by pr-codex bot

Loading

deemp commented Jul 10, 2024 •

edited

Loading

deemp Jul 17, 2024 •

edited

Loading