Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IRC username case sensitivity #63

Open
cg505 opened this issue Mar 12, 2019 · 0 comments
Open

Fix IRC username case sensitivity #63

cg505 opened this issue Mar 12, 2019 · 0 comments
Labels

Comments

@cg505
Copy link
Member

cg505 commented Mar 12, 2019

IRC usernames are not case sensitive, but in some cases, we assume they are. For instance, IRCBot.irc_users is a map from strings to IRCUsers,
where the keys are usernames. (example misuse) This cases an unhandled exception when you send the DM "Cooperc: test" to irc-bridge from slack.

We should look through the code and make sure we haven't made this mistake in other places as well.

@jvperrin jvperrin added the bug label Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants