Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set reasonable character limits for contributions #2113

Closed
dotmacro opened this issue Jun 24, 2024 · 4 comments · Fixed by #2157
Closed

Set reasonable character limits for contributions #2113

dotmacro opened this issue Jun 24, 2024 · 4 comments · Fixed by #2157
Assignees
Labels
Kind:Bug Kind:Enhancement Improvements, new features, performance upgrades, etc. Note:UI/UX Priority:High

Comments

@dotmacro
Copy link
Member

dotmacro commented Jun 24, 2024

Problem

The text boxes on the contribution screen seem to accept an unlimited number of characters. (For reference, I gave up after 30k chars.) Among other issues, this can make the contributions screen unnecessarily long, and make it difficult for users to see any contributions that are listed between/under lengthy contribution descriptions. This will affect all members, as the lengthy descriptions will show up under either "Receiving" or "Giving".

contributions-noCharLimits

Solution

  • Limit the input to a reasonable number of characters.
  • Indicate the user has reached the char limit the same way we do with usernames and group descriptions: an error with the text "Contribution descriptions cannot exceed N characters."
  • Enhancement: Allow a portion of long descriptions to be hidden under a "more..." toggle.
@dotmacro dotmacro added Kind:Bug Kind:Enhancement Improvements, new features, performance upgrades, etc. Priority:Low Note:UI/UX labels Jun 24, 2024
@Silver-IT Silver-IT self-assigned this Jun 24, 2024
@Silver-IT
Copy link
Member

@taoeffect, what do you think is the best reasonable number of characters for this non-monetary contribution?

@taoeffect
Copy link
Member

150 characters is fine.

@Silver-IT
Copy link
Member

If it is 150, do we need more ... toggle?

@taoeffect
Copy link
Member

@Silver-IT no, limiting it to 150 is fine, and you can show the x/150 counter above the field here too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind:Bug Kind:Enhancement Improvements, new features, performance upgrades, etc. Note:UI/UX Priority:High
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants