Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage #2

Open
5 tasks
DavisRayM opened this issue Apr 22, 2021 · 2 comments
Open
5 tasks

Increase test coverage #2

DavisRayM opened this issue Apr 22, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@DavisRayM
Copy link
Contributor

DavisRayM commented Apr 22, 2021

Requested Changes

Currently the test coverage across the codebase is at around 75% we should look into increasing the coverage to 95% minimum:

Name                           Stmts   Miss  Cover
--------------------------------------------------
app/__init__.py                    0      0   100%
app/common_tags.py                 5      0   100%
app/database.py                    7      0   100%
app/jobs/jobs.py                  13      6    54%
app/jobs/scheduler.py             27     12    56%
app/libs/s3/client.py             30     20    33%
app/libs/tableau/client.py        24     18    25%
app/main.py                       51     14    73%
app/models.py                    141      6    96%
app/routers/__init__.py            0      0   100%
app/routers/configuration.py      60     14    77%
app/routers/file.py              142     30    79%
app/routers/oauth.py              63      7    89%
app/routers/server.py             28      3    89%
app/schemas.py                   103      0   100%
app/settings.py                   33      0   100%
app/utils/__init__.py              0      0   100%
app/utils/auth_utils.py           71      9    87%
app/utils/hyper_utils.py          53     38    28%
app/utils/onadata_utils.py       126     74    41%
app/utils/utils.py                34     26    24%
--------------------------------------------------
TOTAL                           1011    277    73%

Suggested breakdown

  • Increase coverage for /app/utils/utils.py
  • Increase coverage for /app/utils/onadata_utils.py
  • Increase coverage for /app/utils/hyper_utils.py
  • Increase coverage for /app/utils/auth_utils.py
  • Increase coverage for /app/libs/tableau/client.py & /app/libs/s3/client.py
@DavisRayM DavisRayM added enhancement New feature or request good first issue Good for newcomers labels Apr 22, 2021
@AlfiyaZi
Copy link

Can I take this task?

@DavisRayM
Copy link
Contributor Author

@AlfiyaZi yes, feel free to pick this up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants