chore(storage): smallish refactoring series, part 1 #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed aliased type to bool. Go aliased types (i.e. type A = B) are a syntactic sugar only. This is different from type redefinitions (i.e. type A B), which create a new type for the compiler. The original intent was to construct some kind of enumerated type, for a... boolean. I chose to remove all this and just go back to plain bool. * contributes #374 Signed-off-by: Frederic BIDON <[email protected]>
Signed-off-by: Frederic BIDON <[email protected]>
|
The goal was to force use of the named values vs. true and false which require jumping around in code to know what it means.. I am ok with a builder pattern to executes similar to the google sdk |
|
I understood the goal, and enforcement is not achieved with aliased types. I feel that the choice of wording in the constants was at best misleading, and ended up with something less readable than the plain |
kerneltime
approved these changes
Feb 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed aliased type to bool.
Go aliased types (i.e. type A = B) are a syntactic sugar only.
This is different from type redefinitions (i.e. type A B), which create a new type for the compiler.
The original intent was to construct some kind of enumerated type, for a... boolean.
I chose to remove all this and just go back to plain bool.
Signed-off-by: Frederic BIDON [email protected]