Browserify-compatible

[Reggino]

Thank your for this, this stuff is awesome.

It can be used in the browser too! Browserify can be used to get it in the browser, but a minor tweak is needed. faye-websocket is not browserify-compatible and not needed since most modern browsers have WebSocket abilities themselves.

[Batistleman]

+1

[c58]

+1

[flippyhead]

👍

[vsivsi]

If many people want this, the fastest way to make it happen will be for someone to put together a PR with the changes Given that this has been sitting here for 6 months, there doesn't appear to be sufficient interest among the maintainers to take the time to do it (myself included).
Edited because apparently I'm not very observant sometimes...

[flippyhead]

But this is a PR with those changes. Only someone with write access can accept and merge it though..

[vsivsi]

Doh, I clearly didn't get enough sleep last night...

[vsivsi]

@flippyhead I can only speak for myself, but the issue here is that adding browser support massively increases the test/validation/support surface of this package. It would be trivial to merge this PR and push a new version of the package to npm. But highly non-trivial to ensure that it works correctly on every browser implementing websockets. And what happens with older browsers?

I guess what I'm saying is that this feels more experimental than production, and tons of production things depend on this package, So absent someone who is willing to make the effort to (re)write all of the test cases for the browser environment, and then actually test across a bunch of different browsers, and also commit to fielding the inevitable questions and fix the issues that arise...

My 2¢ on why nobody has jumped on it (myself included).

[vsivsi]

I feel like the presence of window.Websocket should be the actual test here. And code should be added to detect when it is being run in a non-Websocket implementing browser and do something more helpful that throwing during package load on the absence of window.Websocket (which is presumably what happens now in that case)