New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PIN2 in memory after NFC signing #533

Merged

Counter178 merged 1 commit into open-eid:master from martenrebane:MOPPAND-1346

Jul 16, 2024

Contributor

martenrebane commented Jul 4, 2024

MOPPAND-1346

Signed-off-by: Marten Rebane [email protected]


          Fix PIN2 in memory after NFC signing

53d7aca

github-advanced-security bot found potential problems

View reviewed changes

app/src/main/java/ee/ria/DigiDoc/android/signature/update/nfc/NFCOnSubscribe.java

@@ @@ -104,9 +105,11 @@ @@
                           // pad the PIN and use the chip for verification
                           byte[] paddedPIN = Hex.decode("ffffffffffffffffffffffff");
-                          byte[] pin2b = pin2.getBytes(StandardCharsets.UTF_8);
-                          System.arraycopy(pin2b, 0, paddedPIN, 0, pin2b.length);
+                          System.arraycopy(pin2, 0, paddedPIN, 0, pin2.length);

Check warning

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable

pin2

may be null at this access as suggested by

this

null guard.

ambrose40 approved these changes

View reviewed changes

Counter178 merged commit 5397028 into open-eid:master

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment