Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valve position reporting #67

Open
mdbartos opened this issue May 22, 2018 · 3 comments
Open

Valve position reporting #67

mdbartos opened this issue May 22, 2018 · 3 comments

Comments

@mdbartos
Copy link
Member

For the sake of record-keeping, valve should report -1 * (received position) instead of just -1 when acknowledging a command.

@bpwong-um
Copy link
Contributor

That can be done here

readings[*array_ix] = -1;

We'll have to include a special case for when the desired position is 0

@mdbartos
Copy link
Member Author

Actually, on second thought we should probably just report the moved-to position as a separate measurement. achieved_position or something like that.

@bpwong-um
Copy link
Contributor

The latest firmware transmits the current valve position, which let's us continuously track the position whether it was remotely-triggered or moved manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants