Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Implement Shimmer while user details are being loaded #2412

Open
PratyushSingh07 opened this issue Oct 19, 2023 · 21 comments · May be fixed by #2443
Open

Feat: Implement Shimmer while user details are being loaded #2412

PratyushSingh07 opened this issue Oct 19, 2023 · 21 comments · May be fixed by #2443

Comments

@PratyushSingh07
Copy link
Collaborator

PratyushSingh07 commented Oct 19, 2023

Summary:

I would love to implement a shimmer that is displayed while the details are being loaded.

Steps to reproduce:

When you open the mobile application then the layout showing the user image and name are empty at first because they are being loaded.
At such a point a shimmer effect would be good to have.

@ShivanshKumar4265
Copy link

@PratyushSingh07 I want to work on this issue, please assign me.

@PratyushSingh07
Copy link
Collaborator Author

Sure , go ahead

@ghost
Copy link

ghost commented Nov 2, 2023

@CodeXstalker Are you still working on it...?if not i can work on this

@ShivanshKumar4265
Copy link

@Thanush66 I am working on it

@kmanikanta335
Copy link
Contributor

can i work on this issue @PratyushSingh07 ?

@PratyushSingh07
Copy link
Collaborator Author

@CodeXstalker are you still working on it ? please give us an update about your progress. If there hasnt been any progress then I would like to re-assign it to someone else

Also @kmanikanta335 , if @CodeXstalker gives up on this issue then it will be assigned to @Thanush66 since he had asked earlier. You will be assigned this issue only if these 2 no longer work on it

@kmanikanta335
Copy link
Contributor

@PratyushSingh07 In that case please assign me any other good first issues, I would like to contribute

@ShivanshKumar4265
Copy link

@PratyushSingh07 you can assign to others.

@PratyushSingh07
Copy link
Collaborator Author

@Thanush66 , do you want to work on it ? if not then I will pass this to @kmanikanta335

@ghost
Copy link

ghost commented Nov 11, 2023

@PratyushSingh07 Yeah I will be working on it..

@PratyushSingh07 PratyushSingh07 assigned ghost and unassigned ShivanshKumar4265 Nov 11, 2023
@kmanikanta335
Copy link
Contributor

hey @PratyushSingh07 unfortunately I have completed my work on this issue
can I make a pullrequest

2142.mp4

@PratyushSingh07
Copy link
Collaborator Author

No @kmanikanta335, you cannot make a PR as this isn't assigned to you.
Also this isn't where I was expecting the shimmer. I wanted that in the home screen when the user image and text is being loaded. So your PR won't be able to solve the exact issue

@kmanikanta335
Copy link
Contributor

@Thanush66 yeah can you solve this issue ? if yes how many days ?
I can solve this in one day please leave this to me , I really want to become an contributor since I am new and you already an contributor

@jarvision-git
Copy link

jarvision-git commented Nov 13, 2023

Hi, I have worked on this issue and want your feedback. I know I haven't been assigned to the case, but I worked on this issue to gain insight into how the app functions.

I have set the network type to UMTS so that the shimmer effect is properly visible while the data is being fetched.
(u can skip to 30 sec after a few seconds into the video)

Rec.0009.mp4

This is how it would look like in Full network:

Rec.0010.mp4

@PratyushSingh07, please share your review on this

ps: I don't expect this to be merged. I only worked on the issue to have a better understanding of the app since I'm very new to open source.

@PratyushSingh07
Copy link
Collaborator Author

Awesome job @jarvision-git , the effect being showcased in full network is what I actually want.

@kmanikanta335
Copy link
Contributor

@Thanush66 yeah are u still working on it ?

@ghost
Copy link

ghost commented Nov 18, 2023

@PratyushSingh07 Can you re-assign it.?

@PratyushSingh07 PratyushSingh07 assigned kmanikanta335 and unassigned ghost Nov 18, 2023
@PratyushSingh07
Copy link
Collaborator Author

You Can work on it @kmanikanta335

@kmanikanta335
Copy link
Contributor

@PratyushSingh07 ok I am on it

kmanikanta335 added a commit to kmanikanta335/mifos-mobile that referenced this issue Nov 26, 2023
Feat openMF#2412: Implement Shimmer while user details are being loaded

Feat openMF#2412: Implement Shimmer while user details are being loaded

Feat openMF#2412: Implement Shimmer while user details are being loaded

Feat openMF#2412: Implement Shimmer while user details are being loaded
@KUSHAL-RAJ-PAREEK
Copy link

is this fixed.

@r1shhh1
Copy link

r1shhh1 commented Feb 22, 2024

is this issue closed or still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants