Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify terminology for no changelog needed #135

Open
hustodemon opened this issue Oct 4, 2018 · 4 comments
Open

Unify terminology for no changelog needed #135

hustodemon opened this issue Oct 4, 2018 · 4 comments

Comments

@hustodemon
Copy link

For re-running tests we have the rerun command. For disabling changelog_test we have no changelog needed !!!. I'd find this more intuitive:

gitarro no changelog_test !!! # this would also rerun the changelog test

Advantages:

  • it follows the <command> <test> terminology
  • it refers to the test by it's name (changelog_test, and not just changelog)
  • it could be possibly extended for other tests (not saying this is a good idea in general, but sometimes it could be useful)
@MalloZup
Copy link
Contributor

MalloZup commented Oct 4, 2018

@hustodemon thx i can agree that having a generic mechanism for not running tests can be a feature. thx.

I would say it should rerun just only one time and make it green. ( this could be more tricky to implement, because gitarro is not storing any data about the PR status. but it could be ok).

@MalloZup
Copy link
Contributor

MalloZup commented Oct 5, 2018

@hustodemon if you want to contribute on this pr i will point you few starter for contributing otherwise i think for the moment i cannot take it.

Thank you much for issue and feel free to open others.

@MalloZup
Copy link
Contributor

MalloZup commented Oct 5, 2018

For any contributors:

feel free to ping me on this issue about the details, help etc.

@MalloZup MalloZup added the EPIC label Oct 10, 2018
@MalloZup
Copy link
Contributor

This GitHub PR is unactive since more then 50 days. Is this GitHub PR still needed? Please close or update it accordingly.
This reminder is autogenerated by https://github.com/MalloZup/blacktango

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants