Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #172

Open
srbarrios opened this issue Jun 14, 2019 · 0 comments
Open

Improve test coverage #172

srbarrios opened this issue Jun 14, 2019 · 0 comments

Comments

@srbarrios
Copy link
Contributor

srbarrios commented Jun 14, 2019

It would be interesting to review the rspec test and see how we can improve them.
Things in mind:

  • Better naming and structure of secondary_spec.rb and secondary2.spec, understanding the reasons behind the current structure
  • We currently have features where the list of prs to be processed is important, as sometimes we skip it, sometimes we force one pr. We could try to add more coverage, for instance, checking if we perform more than one context or more than one PR.
  • Test the behaviour of force_test and pr_number parameters separately:
    • --PR pr_number should skip the list of pending prs, only processing the specified PR
    • --force_test that will directly run the test for that PR number without check other filters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant