Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make isOverflowVisible on ModalDialog a required prop without a default value? #3116

Open
brian-smith-tcril opened this issue Jul 2, 2024 · 0 comments

Comments

@brian-smith-tcril
Copy link
Contributor

As of #2939, isOverflowVisible on ModalDialog defaults to true. This can lead to issues such as openedx/frontend-app-course-authoring#986.

If, however, isOverflowVisible is false - we encounter the original problem seen in #2938.

With the current implementation either value being set as the default will lead to some consumers encountering unintended behavior, so I'd like to propose we don't set a default and instead require consumers decide if they want overflow or not.

It's also possible there's a more robust solution I haven't thought of yet, and this may tie in to #2990 somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant