Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused, undocumented argument assume_missing_is_default in check_handler_compatibility #1843

Open
mattwthompson opened this issue Mar 21, 2024 · 0 comments

Comments

@mattwthompson
Copy link
Member

Is your feature request related to a problem? Please describe.

self, other_handler, assume_missing_is_default=True

self, other_handler, assume_missing_is_default=True

Describe the solution you'd like

Remove these since they do nothing but confuse me and any user who tries to understand what they do

Describe alternatives you've considered

Additional context

In this PR, this argument was removed from several other methods of the same name, but not these two: ea4231f

This is an "API break" except it currently does nothing and should not exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant