Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad SMIRNOFF links #184

Closed
dwhswenson opened this issue Sep 16, 2019 · 4 comments · Fixed by #198
Closed

Bad SMIRNOFF links #184

dwhswenson opened this issue Sep 16, 2019 · 4 comments · Fixed by #198
Assignees

Comments

@dwhswenson
Copy link
Member

Related to #114, #121 (etc.)

There are several other places that have the broken link (topology/smirnoff.html), the FAQ being one of the more problematic. Here's a search that finds them:

https://github.com/openforcefield/openforcefield.org/search?q=%22topology%2Fsmirnoff%22

Posting as a separate issue because it can fixed without fixing the details of getting a working stable docs build discussed in #121.

@jchodera jchodera added the bug Something isn't working label Sep 16, 2019
@jchodera
Copy link
Member

Thanks for catching this, @dwhswenson!

@jchodera jchodera added broken links and removed bug Something isn't working labels Sep 16, 2019
@jchodera jchodera self-assigned this Sep 16, 2019
@jchodera
Copy link
Member

It appears that this was due to the decision to delete the topology branch, which also scrubbed it from the readthedocs page.

We can replace most of these with the RTD link for the latest SMIRNOFF specification should be:
https://open-forcefield-toolkit.readthedocs.io/en/latest/smirnoff.html

However, I think some of those items linked to the draft proposal, which would have been closer to this version which is no longer on readthedocs.

I'll fix these.

@davidlmobley
Copy link
Contributor

Have these been fixed, @jchodera ?

@jchodera
Copy link
Member

Whoops! Fixed here: #198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants