Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No code query parameter in the redirect url throws exception #813

Open
DylanRJ opened this issue Jan 11, 2024 · 0 comments
Open

No code query parameter in the redirect url throws exception #813

DylanRJ opened this issue Jan 11, 2024 · 0 comments
Labels
bug triage Issues that need to be triaged

Comments

@DylanRJ
Copy link

DylanRJ commented Jan 11, 2024

Describe the bug
In testing our project authentication implementation using the AppAuth-iOS package, we have noticed that a redirect url without an authentication code parameter throws and NSException, crashing the app. This behaviour feels incorrect as we can't gracefully handle the situation in an error scenario.

To Reproduce
Steps to reproduce the behavior:

  1. Go to demo implementation where the resource server has an option to return a redirect url with no code query parameter
  2. Tap on option to return a redirect url with no code query parameter
  3. See that app crashes

Expected behavior
We would expect that some kind of NSError would be returned to the authState callback which could then be handled.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment

  • Device: [ e.g. iPhone SE (2nd Generation ]
  • OS: [ iOS 17.2 ]

Additional context
Add any other context about the problem here.

@DylanRJ DylanRJ added bug triage Issues that need to be triaged labels Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug triage Issues that need to be triaged
Projects
None yet
Development

No branches or pull requests

1 participant