-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Image and ActionableButton Widget to add ability to copy text #3040
Merged
Merged
Changes from 5 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
8dd2984
Enhance Actionable Button to add ability to copy text
SebaMutuku b653da5
Remove unnecessary icon
SebaMutuku 37f8b56
Run spotlessApply
SebaMutuku ffdad0f
Remove context as param from Composable function
SebaMutuku bae78d8
Merge branch 'main' into fix_issue_3033_add_copy_text_widget
SebaMutuku 889926a
Merge branch 'main' into fix_issue_3033_add_copy_text_widget
pld 23e2cab
Merge branch 'main' into fix_issue_3033_add_copy_text_widget
SebaMutuku 4028f40
Refactor Image Widget to enable on click
SebaMutuku 0d9565f
Merge branch 'fix_issue_3033_add_copy_text_widget' of github.com:open…
SebaMutuku 0e97195
Remove unnecessary ActionableButton previews
SebaMutuku 84182ef
Add text property
SebaMutuku 5723b56
Run spotlessApply
SebaMutuku 43fcd0f
Fix failing tests and add test to confirm toast is shown
SebaMutuku e70a605
Run spotlessApply
SebaMutuku 870e97a
Add text color
SebaMutuku a6ac600
Merge branch 'main' into fix_issue_3033_add_copy_text_widget
pld fc5091d
Update button as per design requirements
SebaMutuku e0d88fa
Merge branch 'fix_issue_3033_add_copy_text_widget' of github.com:open…
SebaMutuku e2b9fb6
Add condition when clicking an image
SebaMutuku 90e5857
Run spotlessApply on Image.kt
SebaMutuku 2d956e9
Add docs for Copy data on actionable button
SebaMutuku ec0c421
Merge branch 'main' into fix_issue_3033_add_copy_text_widget
SebaMutuku 815aab9
Merge branch 'main' into fix_issue_3033_add_copy_text_widget
SebaMutuku 1658100
Add tests for ConfigurationRegistry.writeFile()
SebaMutuku eb48629
Merge branch 'main' into fix_issue_3033_add_copy_text_widget
SebaMutuku File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
<vector xmlns:android="http://schemas.android.com/apk/res/android" | ||
android:width="225dp" | ||
android:height="225dp" | ||
android:viewportWidth="225" | ||
android:viewportHeight="225"> | ||
<path | ||
android:pathData="M60.7,1.7c-7.6,2.6 -16,10.9 -18.2,18 -0.6,2.2 -0.5,2.3 7,2.3 7.1,-0 7.9,-0.2 11.7,-3.3l4,-3.2 56.4,-0.3c55,-0.2 56.5,-0.2 60.4,1.8 2.6,1.3 4.7,3.4 6,6 2,3.9 2,5.3 1.8,75.1l-0.3,71 -4.2,4c-2.3,2.1 -4.8,3.9 -5.6,3.9 -1.2,-0 -1.4,-7.6 -1.5,-46.5 0,-33.1 -0.4,-47.6 -1.3,-50.3 -0.8,-2.7 -6.3,-8.9 -20.8,-23.5 -10.8,-10.9 -21.4,-20.8 -23.6,-22 -3.9,-2.2 -4.8,-2.2 -47,-2.2l-43,-0 -5.7,2.8c-6.1,3 -10.5,7.4 -14,14l-2.3,4.2 0,75 0,75 2.9,5.3c3.3,6 7.6,10.1 13.9,13.4l4.2,2.3 57.5,-0 57.5,-0 5.1,-2.7c5.3,-2.8 11.2,-8.7 13.8,-13.6 1.4,-2.7 2,-5.2 3,-13.1 0.2,-2 1.2,-2.6 5,-3.6 9.2,-2.4 18.1,-11.2 20.6,-20.5 0.7,-2.6 1,-28.6 0.8,-76.7l-0.3,-72.8 -2.9,-5.3c-3.3,-6 -7.6,-10.1 -13.9,-13.4l-4.2,-2.3 -59,-0.2c-52,-0.2 -59.6,-0 -63.8,1.4zM123,56.2c0,14.7 2.6,20.9 11.2,26.5 3.7,2.5 5,2.8 16.4,3.1l12.4,0.4 0,56.8 0,56.7 -2.3,3.4c-4.7,7.1 -3.2,6.9 -61.5,6.9 -50.4,-0 -52.4,-0.1 -56.2,-2 -2.6,-1.3 -4.7,-3.4 -6,-6 -2,-3.9 -2,-5.3 -1.8,-74.9l0.3,-71 3,-3.2c5.5,-5.8 5.5,-5.8 46.8,-5.9l37.7,-0 0,9.2z" | ||
android:fillColor="#000000" | ||
android:strokeColor="#00000000"/> | ||
<path | ||
android:pathData="M53,90.5c-3.4,3.7 -3.3,9 0.4,12.1 2.7,2.4 2.8,2.4 29.2,2.4l26.5,-0 2.4,-2.5c3.4,-3.3 3.4,-8.7 0,-12l-2.4,-2.5 -26.9,-0 -26.9,-0 -2.3,2.5z" | ||
android:fillColor="#000000" | ||
android:strokeColor="#00000000"/> | ||
<path | ||
android:pathData="M54.9,127.5c-5.8,3.2 -5.8,12 0.1,15 4.3,2.2 83.7,2.2 88,-0 5.8,-3 6.7,-9 2.1,-13.6l-2.9,-2.9 -42.4,-0c-34.2,0.1 -42.8,0.3 -44.9,1.5z" | ||
android:fillColor="#000000" | ||
android:strokeColor="#00000000"/> | ||
<path | ||
android:pathData="M53,167.5c-3.4,3.7 -3.3,9 0.4,12.1l2.7,2.4 43,-0 43.1,-0 2.9,-2.9c1.6,-1.6 2.9,-3.9 2.9,-5.1 0,-2.9 -2.6,-7.6 -4.5,-8.4 -0.9,-0.3 -21.1,-0.6 -44.9,-0.6l-43.3,-0 -2.3,2.5z" | ||
android:fillColor="#000000" | ||
android:strokeColor="#00000000"/> | ||
</vector> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a verification done for this perform click action?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update the test to test on click function instead