Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zimcheck should check for empty <title> entry #272

Open
kelson42 opened this issue Dec 18, 2021 · 3 comments
Open

zimcheck should check for empty <title> entry #272

kelson42 opened this issue Dec 18, 2021 · 3 comments

Comments

@kelson42
Copy link
Contributor

kelson42 commented Dec 18, 2021

This is important that HTML front-article have a valid/non-empty <title> entry... or even a non-existing <title> tag! Otherwise the whole Kiwix suggestion system will fail. See for example openzim/ted#125

@mgautierfr
Copy link
Collaborator

Agree. But we may have false positive.
Once the zim is written, the both situations "title is empty" and "title==path" are equivalent and not distinguishable.

As said in openzim/ted#125 (comment) if no entry has a title, we don't have a title index at all. We may check for that first.
We can also loop over all the entries in the xapian title index and the front article list and compare the entries. By definition, front articles are put in the front articles list AND indexed in the xapian title index. But if the real title is empty, it is not indexed. So we can detect that something goes wrong at a moment.
But it is probably a bit more complex (not necessarily complex, but we have never checked a xapian database before)

@kelson42
Copy link
Contributor Author

kelson42 commented Dec 22, 2021

@mgautierfr Your proposal seems to be an other way to come to the same diagnostic. No opinion for the moment what would be the best approach... But we should better check it because missing titles have a quite strong impact on UX.

@kelson42 kelson42 modified the milestones: 3.1.1, 3.2.0 Apr 27, 2022
@kelson42 kelson42 modified the milestones: 3.2.0, 3.3.0 Aug 6, 2022
@kelson42 kelson42 modified the milestones: 3.2.0, 3.3.0 Mar 22, 2023
@kelson42
Copy link
Contributor Author

This ticket is clearly blocked by #331

@kelson42 kelson42 modified the milestones: 3.3.0, 3.4.0 Sep 26, 2023
@kelson42 kelson42 modified the milestones: 3.4.1, 3.5.0 May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants