Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for not skipping POM project type #108

Open
zmeggyesi opened this issue Jun 17, 2021 · 0 comments
Open

Support for not skipping POM project type #108

zmeggyesi opened this issue Jun 17, 2021 · 0 comments

Comments

@zmeggyesi
Copy link

Perhaps my use-case is a bit unique, but here goes...
I have a large monorepository that includes both several Java projects and a number of custom Dart modules in a separate directory. I have my protobuffers in another project that's pulled in as a Git submodule, and then the protoc compiler is run from two places in two executions:

  • One of the Java projects defines one execution that generates Java classes. This one works perfectly.
  • Because I need Dart code as well, I'm also running the compiler from the root project, with the output directory set to my Dart package folder.

Problem is, since the root project has a packaging of POM, the plugin skips execution here. Normally, this would be good, but for my particular use-case, I actually need to be able to run the plugin there as well.

Would there be opposition to adding an extra parameter to the plugin to "skip the skipping", with a default value to make sure the default operation remains unchanged?

zmeggyesi added a commit to zmeggyesi/protoc-jar-maven-plugin that referenced this issue Jun 17, 2021
zmeggyesi added a commit to zmeggyesi/protoc-jar-maven-plugin that referenced this issue Jun 17, 2021
Rationale: in certain use cases, it may happen that the plugin needs to operate on certain directories of an otherwise POM-packaged project. The new switch allows this to happen, while maintaining backwards compatibility by defaulting to the previous operation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant