remove err from kahn.add

osspkg · Dec 31, 2023 · 2416f0b · 2416f0b
1 parent 8c895de
commit 2416f0b
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 35 deletions.
diff --git a/graph/kahn/type.go b/graph/kahn/type.go
@@ -36,12 +36,11 @@ func New() *Graph {
 }
 
 // Add - Adding a graph edge
-func (k *Graph) Add(from, to string) error {
+func (k *Graph) Add(from, to string) {
 	if _, ok := k.graph[from]; !ok {
 		k.graph[from] = make(map[string]int)
 	}
 	k.graph[from][to]++
-	return nil
 }
 
 func (k *Graph) BreakPoint(point string) {

diff --git a/graph/kahn/type_test.go b/graph/kahn/type_test.go
@@ -14,14 +14,14 @@ import (
 
 func TestUnit_KahnCoherent(t *testing.T) {
 	graph := New()
-	require.NoError(t, graph.Add("a", "b"))
-	require.NoError(t, graph.Add("a", "c"))
-	require.NoError(t, graph.Add("a", "d"))
-	require.NoError(t, graph.Add("a", "e"))
-	require.NoError(t, graph.Add("b", "d"))
-	require.NoError(t, graph.Add("c", "d"))
-	require.NoError(t, graph.Add("c", "e"))
-	require.NoError(t, graph.Add("d", "e"))
+	graph.Add("a", "b")
+	graph.Add("a", "c")
+	graph.Add("a", "d")
+	graph.Add("a", "e")
+	graph.Add("b", "d")
+	graph.Add("c", "d")
+	graph.Add("c", "e")
+	graph.Add("d", "e")
 	require.NoError(t, graph.Build())
 	result := graph.Result()
 	require.True(t, len(result) == 5)
@@ -30,14 +30,14 @@ func TestUnit_KahnCoherent(t *testing.T) {
 
 func TestUnit_KahnCoherentBreakPoint(t *testing.T) {
 	graph := New()
-	require.NoError(t, graph.Add("a", "b"))
-	require.NoError(t, graph.Add("a", "c"))
-	require.NoError(t, graph.Add("a", "d"))
-	require.NoError(t, graph.Add("a", "e"))
-	require.NoError(t, graph.Add("b", "d"))
-	require.NoError(t, graph.Add("c", "d"))
-	require.NoError(t, graph.Add("c", "e"))
-	require.NoError(t, graph.Add("d", "e"))
+	graph.Add("a", "b")
+	graph.Add("a", "c")
+	graph.Add("a", "d")
+	graph.Add("a", "e")
+	graph.Add("b", "d")
+	graph.Add("c", "d")
+	graph.Add("c", "e")
+	graph.Add("d", "e")
 	graph.BreakPoint("d")
 	require.NoError(t, graph.Build())
 	result := graph.Result()
@@ -47,18 +47,18 @@ func TestUnit_KahnCoherentBreakPoint(t *testing.T) {
 
 func TestUnit_KahnCoherentBreakPoint2(t *testing.T) {
 	graph := New()
-	require.NoError(t, graph.Add("a", "b"))
-	require.NoError(t, graph.Add("a", "c"))
-	require.NoError(t, graph.Add("a", "d"))
+	graph.Add("a", "b")
+	graph.Add("a", "c")
+	graph.Add("a", "d")
 	graph.BreakPoint("w")
 	require.Error(t, graph.Build())
 }
 
 func TestUnit_KahnCyclical(t *testing.T) {
 	graph := New()
-	require.NoError(t, graph.Add("1", "2"))
-	require.NoError(t, graph.Add("2", "3"))
-	require.NoError(t, graph.Add("3", "2"))
+	graph.Add("1", "2")
+	graph.Add("2", "3")
+	graph.Add("3", "2")
 	require.Error(t, graph.Build())
 }
 
@@ -67,12 +67,12 @@ func Benchmark_Kahn1(b *testing.B) {
 	for i := 0; i < b.N; i++ {
 		func() {
 			graph := New()
-			_ = graph.Add("1", "2") //nolint:errcheck
-			_ = graph.Add("1", "3") //nolint:errcheck
-			_ = graph.Add("3", "4") //nolint:errcheck
-			_ = graph.Add("2", "4") //nolint:errcheck
-			_ = graph.Add("4", "5") //nolint:errcheck
-			_ = graph.Build()       //nolint:errcheck
+			graph.Add("1", "2")
+			graph.Add("1", "3")
+			graph.Add("3", "4")
+			graph.Add("2", "4")
+			graph.Add("4", "5")
+			_ = graph.Build() //nolint:errcheck
 		}()
 	}
 }
@@ -82,11 +82,11 @@ func Benchmark_Kahn2(b *testing.B) {
 	for i := 0; i < b.N; i++ {
 		func() {
 			graph := New()
-			_ = graph.Add("1", "2") //nolint:errcheck
-			_ = graph.Add("1", "3") //nolint:errcheck
-			_ = graph.Add("3", "4") //nolint:errcheck
-			_ = graph.Add("2", "4") //nolint:errcheck
-			_ = graph.Add("4", "5") //nolint:errcheck
+			graph.Add("1", "2")
+			graph.Add("1", "3")
+			graph.Add("3", "4")
+			graph.Add("2", "4")
+			graph.Add("4", "5")
 			graph.BreakPoint("2")
 			_ = graph.Build() //nolint:errcheck
 		}()