strip() will not always behave as desired here

[tyler-jachetta]

avakas/avakas/avakas.py

Line 66 in f554dea

version = version.strip(tag_prefix)

using strip() in this case has some issues (using v as sample prefix):

• if the version string ends with v (e.g. '1.2.3-dev'), trailing v will be stripped
• the first argument to strip is treated as a collection (even though a non-string will raise a TypeError), and all instances of any character in the prefix will be stripped from both ends. Thus:

>>> "aaacdsa".strip('ac')
'ds'
>>> 'version-1.2.3-dev'.strip('version-')
'1.2.3-d'

Don't have tests exercising this done yet, just saw this issue and logging it for now. No known cases of error in the wild

[tyler-jachetta]

also, here:

avakas/avakas/flavors/git.py

Line 132 in f554dea

tags = [t.strip(self.options['tag_prefix']) for t in tags]