Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share api - remove unneeded attributes #254

Open
tomerbsentinel opened this issue Nov 21, 2020 · 1 comment
Open

share api - remove unneeded attributes #254

tomerbsentinel opened this issue Nov 21, 2020 · 1 comment

Comments

@tomerbsentinel
Copy link

Hi,
Please excuse me if I am writing not as per git req. I'm a newbie.

In owncloud.py, line 66-67
`class ShareInfo(object):
"""Share information"""

def __init__(self, share_info):
    self.share_info = {}
    # remove unneeded attributes
    del_attrs = ['item_type', 'item_source', 'file_source', 'parent',
                 'storage', 'mail_send']`

Why did you decide to "drop" the item_type, and item_source or file_source?

My request is to make the folder/file shareable to my group.
From the UI, I can clearly see that the item_source is used:

image

When you "drop" this data, we can't share it with an internal link.

example for internal link:
https://nc.XYZ.com/index.php/f/7790

From the API response:
image

My request:

  1. Is it possible to return all items and let the end-user choose what he needs?

  2. If not all, please remove those from the unneeded:
    'item_type', 'item_source', 'file_source'

  3. If possible, I'd like to do this small PR, let me know if I can contribute.

@tobenary
Copy link

This PR fixes it.
PR-255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants