fix(parser): trailing comma is not allowed in ParenthesizedExpression

[Dunqing]

close: #3878

The implementation is copied from SeparatedList's print_list.

    fn parse_list(&mut self, p: &mut ParserImpl<'a>) -> Result<()> {
        p.expect(self.open())?;

        let mut first = true;

        while !p.at(self.close()) && !p.at(Kind::Eof) {
            if first {
                first = false;
            } else {
                p.expect(self.separator())?;
-                if p.at(self.close()) {
-                    break;
-               }
            }

            self.parse_element(p)?;
        }

        p.expect(self.close())?;
        Ok(())
    }

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[Dunqing]

• fix(parser): trailing comma is not allowed in ParenthesizedExpression #3885 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #3885 will not alter performance

_{Comparing 06-24-fix_parser_trailing_comma_is_not_allowed_in_parenthesizedexpression (ef82c78) with main (41fbe05)}

Summary

✅ 28 untouched benchmarks

[graphite-app]

Merge activity

• Jun 24, 10:52 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jun 24, 10:53 AM EDT: Boshen added this pull request to the Graphite merge queue.
• Jun 24, 11:03 AM EDT: Boshen merged this pull request with the Graphite merge queue.

[DonIsaac]

This logic looks very similar, but ever so slightly different, to the first half of parse_list in TSTypeArgumentList. Is this intentional?

    // crates/oxc_parser/src/ts/list.rs, line 188
    fn parse_list(&mut self, p: &mut ParserImpl<'a>) -> Result<()> {
        p.expect(self.open())?;

        let mut first = true;

        while !p.at(self.close()) && !p.at(Kind::Eof) {
            if first {
                first = false;
            } else {
                p.expect(self.separator())?;
                if p.at(self.close()) {
                    break;
                }
            }

            self.parse_element(p)?;
        }
       // ...
    }

[Boshen]

I don't like the trait implementation any more ... opened #3887

[Dunqing]

This logic looks very similar, but ever so slightly different, to the first half of parse_list in TSTypeArgumentList. Is this intentional?

Yes. Both implementations are copied from the SeparatedList trait.