fix(isolated_declarations): Remove nested AssignmentPatterns from inside parameters

[MichaelMitchell-at]

The default values in destructured parameters are retained in declarations, which can cause captured variables to be part of the emit when they shouldn't be. This can also lead to unnecessary isolated declaration errors when those variables are themselves missing type annotations and can't be inferred.

For example:

const x = 42;
const y = '';
export function fooGood3({a = x, b: [{c = y}]}: object): void {}

before this change will be emitted as:

declare const x = 42;
declare const y = '';
export declare function fooGood3({ a = x, b: [{ c = y }] }: object): void;

and after this change will be emitted as:

export declare function fooGood3({ a, b: [{ c }] }: object): void;

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[codspeed-hq]

CodSpeed Performance Report

Merging #4077 will not alter performance

_{Comparing MichaelMitchell-at:07-07-fix_isolated_declarations_remove_nested_assignmentpatterns_from_inside_parameters (c77db8e) with main (ec14168)}

Summary

✅ 29 untouched benchmarks

[Dunqing]

That's what I thought!