Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(semantic): check for invalid type import assignments #4097

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

DonIsaac
Copy link
Collaborator

@DonIsaac DonIsaac commented Jul 7, 2024

Adds checks to TSImportEqualsDeclaration for invalid use of import type modifier.

import { Foo } from './foo'
namespace Bar {
  export class Baz {}
}

import type A = Foo.Baz;        // not allowed
import type B = Bar.Baz;        // not allowed
import type C = require('./c'); // allowed

@DonIsaac DonIsaac added C-enhancement Category - New feature or request A-semantic Area - Semantic labels Jul 7, 2024
@DonIsaac DonIsaac self-assigned this Jul 7, 2024
Copy link

graphite-app bot commented Jul 7, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-ast Area - AST label Jul 7, 2024
Copy link

codspeed-hq bot commented Jul 7, 2024

CodSpeed Performance Report

Merging #4097 will not alter performance

Comparing don/semantic/up/check-import-assignments (e386b62) with main (3fcad5e)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen requested a review from Dunqing July 8, 2024 02:34
Copy link

graphite-app bot commented Jul 8, 2024

Merge activity

Adds checks to `TSImportEqualsDeclaration` for invalid use of `import type` modifier.

```ts
import { Foo } from './foo'
namespace Bar {
  export class Baz {}
}

import type A = Foo.Baz;        // not allowed
import type B = Bar.Baz;        // not allowed
import type C = require('./c'); // allowed
```
@Dunqing Dunqing force-pushed the don/semantic/up/check-import-assignments branch from 8d2e9cf to e386b62 Compare July 8, 2024 03:14
@graphite-app graphite-app bot merged commit e386b62 into main Jul 8, 2024
24 checks passed
@graphite-app graphite-app bot deleted the don/semantic/up/check-import-assignments branch July 8, 2024 03:18
@github-actions github-actions bot mentioned this pull request Jul 8, 2024
Boshen added a commit that referenced this pull request Jul 8, 2024
## [0.17.2] - 2024-07-08

### Features

- 115ac3b allocator: Introduce `FromIn` and `IntoIn` traits. (#4088)
(rzvxa)
- 720983a napi/transform: Allow setting `sourceType` to `transform`
(#4113) (Boshen)
- e386b62 semantic: Check for invalid type import assignments (#4097)
(DonIsaac)

### Bug Fixes

- 5472b7c codegen: 256 indentations level is not enough for codegen
(Boshen)
- 5c31236 isolated-declarations: Keep literal value for readonly
property (#4106) (Dunqing)
- e67c7d1 isolated-declarations: Do not infer type for private
parameters (#4105) (Dunqing)
- 3fcad5e isolated_declarations: Remove nested AssignmentPatterns from
inside parameters (#4077) (michaelm)
- f8d77e4 isolated_declarations: Infer type of template literal
expressions as string (#4068) (michaelm)
- 0f02608 semantic: Bind `TSImportEqualsDeclaration`s (#4100) (Don
Isaac)
- 4413e2d transformer: Missing initializer for readonly consructor
properties (#4103) (Don Isaac)

### Performance

- 7ed27b7 isolated-declarations: Use `FxHashSet` instead of `Vec` to
speed up the `contain` (#4074) (Dunqing)
- 9114c8e semantic: Keep a single map of unresolved references (#4107)
(Luca Bruno)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST A-semantic Area - Semantic C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants