DataFrame.eval error fixed #59145
DataFrame.eval error fixed #59145
Conversation
| @@ -218,3 +217,12 @@ def reconstruct_object(typ, obj, axes, dtype): | |||
| ret_value = np.array([ret_value]).astype(res_t) | |||
|
|
|||
| return ret_value | |||
|
|
|||
| # Test with the DataFrame and multiline expression | |||
There was a problem hiding this comment.
Can you move the test to a proper test file? I think pandas/tests/test_expressions.py is probably the best place for it.
| @@ -144,8 +145,6 @@ def _align_core(terms): | |||
| obj = ti.reindex(reindexer, axis=axis) | |||
| terms[i].update(obj) | |||
|
|
|||
| terms[i].update(terms[i].value.values) | |||
There was a problem hiding this comment.
Removing this line does fix the bug, nice job! But I'm curious about potential side effects: this line of code converts terms[i].value from pd.Series to np.ndarray, and removing it might affect the behavior of terms in whatever context it is used. Are the test failures related?
There was a problem hiding this comment.
Sure @chaoyihu I have added the test in the respective file
But here what you want me to do further in this terms[i].value ??
|
I have moved the test in the respective file |
DataFrame.evalfails with TypeError with multiline expr but works whenevalline by line #59062 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.