Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from using tokens to construct match spans #413

Closed
ggurdin opened this issue Jul 1, 2024 · 0 comments · Fixed by #453
Closed

Move away from using tokens to construct match spans #413

ggurdin opened this issue Jul 1, 2024 · 0 comments · Fixed by #453
Assignees

Comments

@ggurdin
Copy link
Collaborator

ggurdin commented Jul 1, 2024

Currently we're using tokens to construct match spans in the input bar. This requires a call to the tokenize endpoint in the function justGetTokensAndAddThemToIGCTextData, to prevent the originalInput and the token offsets and length from being out-of-sync. We want to instead use the match data to construct these spans.

@ggurdin ggurdin self-assigned this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant