Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crashes with DeviceOS 2.0.0 due to missing return #12

Open
ScruffR opened this issue Dec 11, 2020 · 1 comment
Open

Crashes with DeviceOS 2.0.0 due to missing return #12

ScruffR opened this issue Dec 11, 2020 · 1 comment

Comments

@ScruffR
Copy link

ScruffR commented Dec 11, 2020

int playLED() fails to return a value and starting with 2.0.0 this causes a SOS panic crash.

Adding return strtol(color, NULL, 0); at the bottom of this function should do the trick

https://github.com/particle-iot/xmastree/blob/master/src/firmware/xmastree.ino#L101
@wesleycombs
Copy link

Thanks @ScruffR - that did the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ScruffR @wesleycombs