Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plain notification bell buttons in masthead to use notification badge #10625

Open
mcoker opened this issue Jun 17, 2024 · 0 comments
Open
Labels
Tech debt improvements to code that do not affect either user or product developers’ experience.
Milestone

Comments

@mcoker
Copy link
Contributor

mcoker commented Jun 17, 2024

There are some plain buttons with a bell icon that look like notification badges that should use the <NotificationBadge> component. For example in the dashboardwrapper

{notificationBadge ?? (
<ToolbarItem>
<Button
aria-label="Notifications"
variant={ButtonVariant.plain}
icon={<BellIcon />}
onClick={() => {}}
/>
</ToolbarItem>
)}

@mcoker mcoker added the Tech debt improvements to code that do not affect either user or product developers’ experience. label Jun 17, 2024
@mcoker mcoker added this to the 2024.Q3 milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tech debt improvements to code that do not affect either user or product developers’ experience.
Projects
Status: Needs triage
Development

No branches or pull requests

1 participant