Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Random shape color #51

Open
1ennard opened this issue Feb 15, 2022 · 3 comments
Open

Feature request: Random shape color #51

1ennard opened this issue Feb 15, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@1ennard
Copy link

1ennard commented Feb 15, 2022

Hello,
thanks for your work! As an additional feature it would be nice to have a option to get a random shape colors for the selected theme. Or maybe random from a few preset colors, so you only get colors that match well.

@patzly patzly added the enhancement New feature or request label Feb 18, 2022
@patzly
Copy link
Owner

patzly commented Feb 18, 2022

Hi, thanks for your request! I'm afraid shape color cannot be simply changed to any color. The wallpaper designs available in the app are static svg files, one for each color combination (and always a light and a dark version). Some designs only contain svg paths, so I could set the color of them to a user-selected color. But other designs (mostly the Pixel 6 collection) contain bitmaps, which cannot be colored/tinted with another color, they are just static. That's why the Pixel 6 collection only contains one variant per design.
I will leave this issue open because a randomizer option for the color variants is a good idea, in future versions I will add more color variants to the Pixel 4 collection. That isn't exactly random shape color, but I hope this will fit your needs, too as I think the color variants selection is equal to the preset colors you mentioned.

@takmilihsan
Copy link

+1 for randomizer option for color variants.

@patzly
Copy link
Owner

patzly commented Sep 19, 2022

Just a note for myself, some ideas for general revision of the internal app structure regarding design and variants (all in the far future when I have too much time):

  • Only one svg file per design (shrinks app size and maybe memory usage!) with meaningful shape ids, shape colors don't matter but should not all be black so the shapes can be recognized in editor preview
  • A wallpaper is a class that contains the svg file resId and the shape ids
  • A variant is a Java object that contains a light and a dark version with colors mapped to shape ids
  • List of variants (room database and exportable?) for each design, containing presets and custom variants
  • Plus icon at the end of variants list -> new custom variant, and tap on any variant to edit colors
  • custom variant page displays (always two at the top and the bottom for light and dark) a color selection for background, a dropdown with all shape ids, a color selection circle with the color of the currently selected shape id, a color randomizer button and a variant preview (also two for light and dark version)
  • Colors in each variant are used in "extracted colors" section for system theming
  • Maybe (would be the icing on the cake) an implementation of the new HTC color system from the Material design team at Google with MDC Android: a "magic" button that takes any selected background color to generate matching shape colors according to the basic shape color/tone/hue of the shape in the original svg file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

3 participants