Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No clean arcitecture is implemented #85

Open
Tishka17 opened this issue Oct 6, 2023 · 0 comments
Open

No clean arcitecture is implemented #85

Tishka17 opened this issue Oct 6, 2023 · 0 comments

Comments

@Tishka17
Copy link

Tishka17 commented Oct 6, 2023

According to Uncle Bob, application and domain layers should implement business logic itself. Minimal magic and usage of frameworks is expected there. Gateway interface should be concrete and defined in terms of business logic (e.g. used by application layer) and located inside the layer which uses it. Gateway interfaces should follow ISP. DTOs should be simple structures without any logic

In current repo I see a lot of magic related to the layers which should not use it at all. Interfaces are unclear. DTO is inheriting from dict so it does not have any clear structure as well.

This repo looks contradicitng the Ideas of Clean Arctitecture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant