Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Could probably reduce latency with an alternative read instruction #4

Open
teauxfu opened this issue May 8, 2021 · 0 comments
Open

Could probably reduce latency with an alternative read instruction #4

teauxfu opened this issue May 8, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@teauxfu
Copy link
Member

teauxfu commented May 8, 2021

Currently using pySerial's read_until for convenience

https://github.com/teauxfu/py-hplc/blob/4df7179edf2abeed33d7223cd5fa2b7df646e40f/py_hplc/pump_base.py#L204

Which is defined as

https://github.com/pyserial/pyserial/blob/0e7634747568547b8a7f9fd0c48ed74f16af4b23/serial/serialutil.py#L654-L674

However, implementing a custom readline instruction may be able to reduce latency (which isn't currently an issue -- at least for my purposes)

pyserial/pyserial#216 (comment)
@teauxfu teauxfu added the enhancement New feature or request label May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@teauxfu