Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require schema seems always on #7

Open
hank123 opened this issue Jun 26, 2015 · 8 comments
Open

require schema seems always on #7

hank123 opened this issue Jun 26, 2015 · 8 comments

Comments

@hank123
Copy link

hank123 commented Jun 26, 2015

Do you have an example on how to turn on schema validation. I followed the example you have from readme, but it seems always validating against schema.

thanks you

@mitar
Copy link
Member

mitar commented Jun 26, 2015

I do not understand your question. What exactly does not work?

@hank123
Copy link
Author

hank123 commented Jun 26, 2015

I am sorry, I mean turn off schema validation. I want to test xml4js without using schema validation.
I also want to see if the fields are double quotes. I tried xml2js , but the generated json fields are not double quoted, is there a way to make it double quoted in xml2js ?

thank you !

Hank

@mitar
Copy link
Member

mitar commented Jun 26, 2015

If you do not want schema validation, then you should use xml2js. What you mean if fields are double quotes?

@jameshowe
Copy link
Contributor

+1 you don't always want to use schema validation and having to include both libraries to support these 2 scenarios seems unnecessary, particularly when this one is capable of doing everything.

@mitar
Copy link
Member

mitar commented Oct 6, 2015

Pull request welcome. :-)

@mitar
Copy link
Member

mitar commented May 3, 2016

having to include both libraries to support these 2 scenarios seems unnecessary

This library depends on xml2js anyway, so you are already "including" both. Now, is is really so hard to make require/import the package you need?

But I agree, this could be a configuration switch. It is probably an easy contribution to make. So please do so.

@jameshowe
Copy link
Contributor

@mitar of course it's not hard, it's just messy.

I'm no longer using this library as xml2js doesn't have support for streaming, however, I still think a configuration option would be useful.

@mitar
Copy link
Member

mitar commented May 3, 2016

True. Streaming would be very useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants