Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we have a delete button for periods that DON'T have URIs yet? #268

Open
atomrab opened this issue Jun 10, 2020 · 3 comments
Open

Can we have a delete button for periods that DON'T have URIs yet? #268

atomrab opened this issue Jun 10, 2020 · 3 comments
Assignees

Comments

@atomrab
Copy link

atomrab commented Jun 10, 2020

I know that we don't want to make it possible for people to delete periods from existing authorities without a really, really good reason. But if we could make a delete button for periods that do not yet have URIs, that would really help with workflow -- I've been working on the Priestley material, and in several cases I accidentally duplicated periods and couldn't delete (the workaround is to make yet another collection and import everything except the duplicate, but it's a pain). So, maybe it would be ok to delete pre-merge period definitions in a local IDB?

@atomrab
Copy link
Author

atomrab commented Jun 10, 2020

On a related note, it was useful to be able to delete local collections individually in the old client, rather than having to either clear all data or keep around an array of IDBs that are no longer useful and just create confusion.

@rybesh
Copy link
Member

rybesh commented Jun 10, 2020

In the latest (development) client you can delete data sources again.

I agree that we need to be able to delete local periods—I ran into this with the ROAD periods. It's very common to create two separate periods and then realize they should be alternate labels for the same period. But then you're stuck with a zombie period that you can't delete, but that you you have to be careful not to include in the patch. And even if you successfully do that, if there are still references to it from other periods it will create an unrejectable client-crashing patch! 😱

@ptgolden
Copy link
Member

Implemented deleting authorities and periods in f2efd11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants