Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strongly typed codebase #5

Open
toinbis opened this issue Apr 2, 2024 · 3 comments
Open

strongly typed codebase #5

toinbis opened this issue Apr 2, 2024 · 3 comments

Comments

@toinbis
Copy link

toinbis commented Apr 2, 2024

As a follow-up to #4 - I would kindly like to ask one more question, if I may.

@pgorecki - would you see strongly-typed codebase would be a goal for lato?

I spent gazillion hours trying to strongly-type python-ddd repo fork. Even found a bug in pyright along the way: python/typing#1451 (reply in thread) :). Spent this weekend trying to strongly type lato...

I think lato is wonderful. But there is little bit of black magic which I am not capable to understand just by looking at code. Strongly typed codebase would help to reason it a lot. Am sure it'd force to restructure some parts of the code, simplify it.

It's a big feature with not necessary clear benefits for you personally (as you know all the codebase by heart). But that'd surely be a nice to have for lato as a publicly used framework.

I'd love to try to contribute to it. But only if you wanted this to happen and provide some guidance. I have strongly-typed lato codebase during the weekend (with the help of chatGPT...;), it could be some starting point. I could open a PR with all the changes, or I don't know how would it be the best to approach it.

But yeah - you willing to see it happening and having to plans to guide/contribute to this happening at least a little bit are both hard requirements to even start thinking about this.

https://github.com/pyeventsourcing/eventsourcing is strongly typed codebase, would you it could be named as a goal for lato framework as well?

Thanks for any thoughts!

@pgorecki
Copy link
Owner

pgorecki commented Apr 3, 2024

Hi @toinbis,

I already made some efforts into introducing type annotations to lato, but it's far from being complete. I like the idea of having strongly typed codebase, unless it will make the code more complicated and harder to maintain. Also, lato shouldn't enforce strong typing on the client code - it should seamlessly function with both typed and untyped Python.

I'm happy to hear that you'd like to contribute. If you need any help, guidance, or better understanding of lato's internals - I'd be happy to help. Feel free to drop me an email and we can schedule a call.

@toinbis
Copy link
Author

toinbis commented Apr 4, 2024

Hey @pgorecki - thanks a lot for reply and clarification!

I suggest I tinker a bit more with a codebase, clarify how I would plan to approach this task - firstly to me myself, and then i'll message you here or linkedin and suggest to schedule a call and discuss it all live. Would that sound like a plan?

Thanks!

@pgorecki
Copy link
Owner

pgorecki commented Apr 4, 2024

Sounds like a plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants