Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TravisCI #37

Closed
jmathai opened this issue May 17, 2013 · 5 comments · Fixed by #40
Closed

Add support for TravisCI #37

jmathai opened this issue May 17, 2013 · 5 comments · Fixed by #40

Comments

@jmathai
Copy link
Member

jmathai commented May 17, 2013

Let's add TravisCI to automatically run the unit tests for commits and merges.

http://about.travis-ci.org/docs/

@sneakypete81
Copy link
Contributor

I've been experimenting with this last week, and have something working - I'll do a PR soon.

Many of the tests are more integration tests than unit tests, and require oauth keys to a test host. Fortunately Travis supports encrypted env vars, so we can so this securely.

@jmathai
Copy link
Member Author

jmathai commented May 21, 2013

Wonderful. I'm also fine setting up a test account specifically for the tests.

For the openphoto/frontend tests we mock everything out (mysql, file system, etc) which helps keep us from getting false positives because of a dependency. It's be nice to work that in here but I'm very very happy to have just this as a start.

@sneakypete81
Copy link
Contributor

Agree about mocking - I'll get to this at some point.

It's been very useful to be able to run the tests against a real host, to thrash out a few API issues.

@jmathai
Copy link
Member Author

jmathai commented May 21, 2013

It helps on the API side too :).

Thanks for the contributions so far. It's really great to have you on board.

@sneakypete81
Copy link
Contributor

Ok, Travis is set up and seems to be working.

It's a bit unstable due to #42, but for now I can manually re-trigger the Travis hook if the build fails due to this.

The eventual goal is to write a fuller set of unit tests and remove the integration tests from Travis run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants