Improvements #18
Open
Improvements #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliadh
commented
Sep 13, 2022
•
eliadh
commented
- Fix standard formatter
- misc refactoring
- remove unused datetime import
Dobatymo
reviewed
Sep 14, 2022
requestlogger/__init__.py
Outdated
| def standard_formatter(status_code, environ, content_length): | ||
| return "{0} {1}".format(dt.now().isoformat(), status_code) | ||
| def standard_formatter(status_code, environ, content_length, **kwargs): | ||
| val = dict() |
There was a problem hiding this comment.
Actually you are right these could be regular variables as well. guess just copy-pasted from the Apache formatter..
anyway, will replace and re-submit the PR. thanks!
|
Hi. |
1) Fix standard formatter 2) misc refactoring
|
also removed unused |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.