Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pokemon nicknames #188

Open
BigDawgJamal opened this issue Mar 15, 2024 · 1 comment
Open

Pokemon nicknames #188

BigDawgJamal opened this issue Mar 15, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@BigDawgJamal
Copy link

BigDawgJamal commented Mar 15, 2024

Howdy!

So im not really that well-versed in coding, but for some reason when you load up the bot with a team, it dosnt include the different nicknames that you have set for them. Ive been trying to mess around with a lot of it for quite a few hours and I got differeing but mostly lacking results, since my coding experince is near to none. It might even just be a problem I have caused myself, then again, I wouldnt know. Im assuming its a feature of the bot since the team_converter, has both "name", and "species".

Could you point me in the right directions? Or maybe test out the bot yourself, to see if the problem exists for you and not just me?Either way, thanks for your hard work on the bot!!

Edit: Sorry for the many questions. But I was also wondering if there was a way of changing or removing the autochat feature?
Edit: It also does not make them shiny. Im not really sure what the issue is, Is there another specific way the information in the "team" file has to be for it to read it correctly?

@pmariglia
Copy link
Owner

Thanks for the issue. Yes this is a problem as I did not write a perfect team parser since I did not care about nicknames when testing.

This function is what would need to change to support allowing nicknames to be pased from the export string.

And then this function would need to change to allow the nickname to be put into the packed format that PokemonShowdown reads.

Here are some docs from PS on how these formats look like..

@pmariglia pmariglia added the good first issue Good for newcomers label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants