Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/hideroom prevents the bot from acting #68

Open
DiscordOdysseyDev opened this issue Jul 6, 2021 · 3 comments
Open

/hideroom prevents the bot from acting #68

DiscordOdysseyDev opened this issue Jul 6, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@DiscordOdysseyDev
Copy link

What the title says, if you use the command /hideroom the bot stops acting for the rest of the game (which means after the bot loses because of timeout), i have been trying to do something about this but my knowledge isn't enough to understand how this bot works. I'm still trying to figure how and why and any help will be much appreciated. I'm posting this here because it seems relevant enough.

Steps to reproduce: Just use /hideroom when facing a bot.

@pmariglia
Copy link
Owner

Nice catch, looks like the room gets renamed when someone uses /hideroom. The bot needs the current name of the room in order to send messages, and it won't parse the following battle log in order to add the random characters to the end of the room:

>battle-gen8randombattle-1372565845
|noinit|rename|battle-gen8randombattle-1372565845-qddmfz5d31w306mbl6odghadmmvzpyjpw

Should be a simple fix - just need to write some battle-log parsing to update the name of the room when it sees a message like this. Ill push a fix when I get a chance.

@pmariglia pmariglia added the bug Something isn't working label Jul 7, 2021
@DiscordOdysseyDev
Copy link
Author

Thanks for the fast response, I'd be glad to help in anything I can but my python knowledge is very basic. I'll stay tuned for updates

@pmariglia
Copy link
Owner

Should be (mostly) fixed in 5c4add9.

There's probably still a weird edge-case where if /hideroom is used while the bot is still thinking. I'll get back to this when I have a bit more time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants