Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[consistency] Consider including _ToMNI substring #20

Open
tashrifbillah opened this issue Apr 4, 2020 · 2 comments
Open

[consistency] Consider including _ToMNI substring #20

tashrifbillah opened this issue Apr 4, 2020 · 2 comments
Assignees
@tashrifbillah
Labels
watch list

Comments

@tashrifbillah
Copy link
Collaborator

This line can have _FA_ToMNI just like this line.

We know _ToMNI was dropped for conciseness but consider bringing it back.
@tashrifbillah tashrifbillah self-assigned this Apr 4, 2020
@tashrifbillah
Copy link
Collaborator Author

Or do we need to drop _ToMNI from single-shell because we are actually warping to template space, not standard space?

@tashrifbillah
Copy link
Collaborator Author

Inconsistency within single-shell:
compare lines:
https://github.com/pnlbwh/dMRIharmonization/blob/spm-bspline/lib/debug_fa.py#L95
versus
https://github.com/pnlbwh/dMRIharmonization/blob/spm-bspline/lib/debug_fa.py#L64

One has underscore while the other does not have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tashrifbillah tashrifbillah

Labels
watch list
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tashrifbillah