Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to newer Python version #64

Open
jhlegarreta opened this issue Aug 8, 2023 · 5 comments
Open

Upgrade to newer Python version #64

jhlegarreta opened this issue Aug 8, 2023 · 5 comments

Comments

@jhlegarreta
Copy link

The current Python version used by the tool (3.6) was deprecated almost 2 years ago (2021-12-23):
https://devguide.python.org/versions/#unsupported-versions

The next version, Python 3.7, is not supported either since 1 year ago.

None of these are shipped on current OS.

Thus, the installation gets stuck when trying to create a Python 3.6 environment on any sufficiently modern platform.

Is there an upgrade to at least Python 3.8 planned?

@tashrifbillah
Copy link
Collaborator

The work that entails is that someone has to remove/update the version specifications in:
https://github.com/pnlbwh/pnlpipe/blob/master/python_env/environment36.yml

Feel free to try it and submit PR if https://github.com/pnlbwh/pnlpipe/tree/master#tests pass. Then we shall do another round of tests: https://github.com/pnlbwh/luigi-pnlpipe/tree/hcp/tests

None of these are shipped on current OS.

What is current and what is OS?

@jhlegarreta
Copy link
Author

Thanks for answering.

Feel free to try it and submit PR

Will submit a PR as time permits.

What is current and what is OS?

Current in my case is Ubuntu 22.04 LTS, and Python 3.10 as default, but have also Python 3.8 installed. For reference, Ubuntu 20.04 (> 3 years old) shipped Python 3.8 already.

@tashrifbillah
Copy link
Collaborator

So all our software are developed on CentOS 7. Its default is 2.7. So we shall always have to install Python 3 no matter what minor version it is.

@jhlegarreta
Copy link
Author

OK, then upgrading to Python 3.8 or newer is a reasonable request.

Do you want me to add a new environment3.x.yml file or do you want me to rename and upgrade the versions in the existing one?

@jhlegarreta
Copy link
Author

Given this answer #65 (comment) I am not going to invest time in testing locally:

Feel free to try it and submit PR if https://github.com/pnlbwh/pnlpipe/tree/master#tests pass.

My PR is in #66 and maintainers will be able to invest time in testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants