Upgrading to rs 0.41.3

[Bidek56]

Upgrading to rs-0.41.3

[Bidek56]

@universalmind303
The only missing test from this PR is expr.test.ts:expr.slice
If you have any ideas how to fix polars/lazy/expr/slice pls LMK thx.

[Bidek56]

Any ideas how to convert this line: ValueType::Number => AnyValue::Float64(f64::from_napi_value(env, napi_val)?),
to return u32 or f64 ? Thx
Apparently it's not an easy task according to SO.

[Bidek56]

Is this conversion from number to either float or int too dangerous of an assumption? It works, but....

ValueType::Number => { 
    let napi_float = f64::from_napi_value(env, napi_val)?;
    if napi_float.fract() != 0.0 {
        AnyValue::Float64(napi_float)
    } else {
        AnyValue::Int32(i32::from_napi_value(env, napi_val)?)                    
    }
},

[universalmind303]

Any ideas how to convert this line: ValueType::Number => AnyValue::Float64(f64::from_napi_value(env, napi_val)?), to return u32 or f64 ? Thx Apparently it's not an easy task according to SO.

why can't it just continue to always return f64?

[Bidek56]

Any ideas how to convert this line: ValueType::Number => AnyValue::Float64(f64::from_napi_value(env, napi_val)?), to return u32 or f64 ? Thx Apparently it's not an easy task according to SO.

why can't it just continue to always return f64?

Because rs-0.41.3 has introduced a int check for the slice method parameters. Passing f64 causes an error.

[Bidek56]

Conversion from f64 to i32:

ValueType::Number => { 
    let napi_float = f64::from_napi_value(env, napi_val)?;
    if napi_float.fract() != 0.0 {
        AnyValue::Float64(napi_float)
    } else {
        AnyValue::Int32(i32::from_napi_value(env, napi_val)?)                    
    }
},

would involve changing this as well:

 case "number":
      return Number.isInteger(value) ? DataType.Int32 : DataType.Float64;

and it would break a number of tests like this one:

    Expected: 
    >>shape: (3, 1)
    ┌───────────┐
    │ eq        │
    │ ---       │
    │ str       │
    ╞═══════════╡
    │ a=a;b=1.0 │
    │ a=b;b=2.0 │
    │ a=c;b=3.0 │
    └───────────┘ 
    Received:
    >>shape: (3, 1)
    ┌─────────┐
    │ eq      │
    │ ---     │
    │ str     │
    ╞═════════╡
    │ a=a;b=1 │
    │ a=b;b=2 │
    │ a=c;b=3 │
    └─────────┘

@universalmind303 Pls LMK how to do you want to proceed. Thx

[universalmind303]

@Bidek56 can't we just cast from f64 to an accepted type

#[napi(catch_unwind)]
    pub fn slice(&self, offset: &JsExpr, length: &JsExpr) -> JsExpr {
        self.inner
            .clone()
            .slice(offset.inner.clone().cast(DataType::Int64), length.inner.clone().cast(DataType::Int64))
            .into()
    }