From d606128dd8aa756a1026185bff2567512a7b48aa Mon Sep 17 00:00:00 2001 From: Buhle Date: Mon, 10 Jul 2023 10:44:38 +0200 Subject: [PATCH] Validate user input for contact number --- yal/tests/test_pleasecallme.py | 10 ++++++++++ yal/validators.py | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/yal/tests/test_pleasecallme.py b/yal/tests/test_pleasecallme.py index 66179efb..047fd675 100644 --- a/yal/tests/test_pleasecallme.py +++ b/yal/tests/test_pleasecallme.py @@ -941,3 +941,13 @@ async def state_state_specify_msisdn_invalid_input_with_plus(tester: AppTester): tester.assert_message( "\n".join(["⚠️ Please type a valid cell phone number.", "Example _081234567_"]) ) + + +@pytest.mark.asyncio +async def state_state_specify_msisdn_empty_input(tester: AppTester): + tester.setup_state("state_specify_msisdn") + await tester.user_input(None) + tester.assert_state("state_specify_msisdn") + tester.assert_message( + "\n".join(["⚠️ Please type a valid cell phone number.", "Example _081234567_"]) + ) diff --git a/yal/validators.py b/yal/validators.py index 7c2642f9..714c8f43 100644 --- a/yal/validators.py +++ b/yal/validators.py @@ -39,7 +39,7 @@ async def validator(value): def phone_number_validator(error_text): async def validator(value): - if value.startswith("+") or value.isdigit(): + if value: try: normalise_phonenumber(value) except ValueError as e: