Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Rofi audio selector #1583

Open
ffrancesco94 opened this issue Jun 13, 2024 · 8 comments · May be fixed by #1588
Open

[Feature Request]: Rofi audio selector #1583

ffrancesco94 opened this issue Jun 13, 2024 · 8 comments · May be fixed by #1588
Labels
enhancement New feature or request

Comments

@ffrancesco94
Copy link

Feature Request

Description

Right now, to change audio source/sink, we right-click on the waybar icon which opens pavucontrol (by the way, there's a bug: pavucontrol is open by default on the first workspace of the main screen, regardless of which workspace is active when the icon is touched). Might be worthwile to make a rofi interface for that that can be called with a keybinding.

Use Case

Makes it easier (and keyboard-only) to change audio source/sink. At first I didn't even realise that pavucontrol was open.

Proposed Solution

Have a rofi audio selector, so that changing source/sink can be done on the fly without actually opening a new window

Alternatives

A good starting point would be to at least open pavucontrol on the active workspace.

Additional Information

Something along those lines is implemented here.

@ffrancesco94 ffrancesco94 added the enhancement New feature or request label Jun 13, 2024
@kRHYME7
Copy link
Collaborator

kRHYME7 commented Jun 13, 2024

(by the way, there's a bug: pavucontrol is open by default on the first workspace of the main screen, regardless of which workspace is active when the icon is touched)

This one is upstream bug will wait for Hyprland to iron this out.

And Yeah the feature request is useful would be cool if we can find an implementation like this. Will try to see what we can do.

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Jun 14, 2024

Should work like this

image

@kRHYME7 kRHYME7 linked a pull request Jun 14, 2024 that will close this issue
@kRHYME7
Copy link
Collaborator

kRHYME7 commented Jun 14, 2024

checkout #1588

@ffrancesco94
Copy link
Author

So from what I understood the selector should appear when right clicking the icon? Doesn't appear for me...

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Jun 17, 2024

Are you sure you fetched the PR?

what is the output when you run volumecontrol.sh -s "" ?

@ffrancesco94
Copy link
Author

volumecontrol.sh -s "" opens the right rofi menu, it's just the right-clicking that doesn't work.

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Jun 17, 2024

So the script works.

Can I see this file?
~/.config/waybar/modules/pulseaudio.jsonc

image

requires a waybar reload (Hyde reload)

@ffrancesco94
Copy link
Author

Found the issue. I had just logged out and in, but it took a whole reboot for it to actually apply. Thank you, it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants