fix(4752): Can't set server description to empty from client UI

[robertnisipeanu]

Fixes #4752

Issue is that the middleware ConvertEmptyStringsToNull is enabled by default by Laravel.

Request:

Values:

New behavior after fix:
If description is not included in the request it will keep the old value.
If description is included but has a value of null or empty string it gets converted to null by the middleware, and then casted to empty string using a (string) cast.
If description is included and not empty, it will save that value.

[Mubeen142]

The suggested code can be simplified by doing

$request->input('description', $server->description);

Instead of

$request->has('description') ? (string) $request->input('description') : $server->description

[Boy132]

The suggested code can be simplified by doing

$request->input('description', $server->description);

Instead of

$request->has('description') ? (string) $request->input('description') : $server->description

No. With $request->input('description', $server->description); you still can't set the description to empty. robertnisipeanu's fix works fine.