Fix TS checks in the common package

.github/workflows/release/reviewers.json

@@ -1,13 +1,8 @@
 {
   "packages/react-native/src/**/*": {
-    "users": [
-      "techwritermat",
-      "are"
-    ]
+    "users": ["techwritermat", "are"]
   },
   "packages/react/src/**/*.ts": {
-    "users": [
-      "parfeon"
-    ]
+    "users": ["parfeon"]
   }
-}
+}

packages/common/src/channel-list/channel-list.tsx

@@ -40,15 +40,15 @@ export const useChannelListCore = (props: CommonChannelListProps) => {
 
   const channelSorter = (a: ChannelEntity, b: ChannelEntity) => {
     if (props.sort) return props.sort(a, b);
-    return a?.name?.localeCompare(b.name as string, "en", { sensitivity: "base" });
+    return a?.name?.localeCompare(b.name as string, "en", { sensitivity: "base" }) as number;
   };
 
   const channelFromString = (channel: ChannelEntity | string) => {
     if (typeof channel === "string") {
       return {
         id: channel,
         name: channel,
-      };
+      } as ChannelEntity;
     }
     return channel;
   };

packages/common/src/helpers.ts

@@ -8,7 +8,7 @@ export const getNameInitials = (name: string): string => {
   return initials.toUpperCase();
 };
 
-export const getPredefinedColor = (uuid: string): string => {
+export const getPredefinedColor = (uuid: string): string | undefined => {
   if (!uuid || !uuid.length) return;
   const colors = ["#80deea", "#9fa7df", "#aed581", "#ce93d8", "#ef9a9a", "#ffab91", "#ffe082"];
   const sum = uuid

packages/common/src/hooks/use-channel-members.ts

@@ -1,5 +1,5 @@
 import { useState, useEffect, useMemo } from "react";
-import { GetChannelMembersParameters } from "pubnub";
+import { GetChannelMembersParameters, ObjectsEvent } from "pubnub";
 import { usePubNub } from "pubnub-react";
 import { merge, cloneDeep } from "lodash";
 import { UserEntity } from "../types";
@@ -55,11 +55,11 @@ export const useChannelMembers = (options: GetChannelMembersParameters): HookRet
           ...members,
           ...(response.data.map((m) => m.uuid) as UserEntity[]),
         ]);
-        setTotalCount(response.totalCount);
-        setPage(response.next);
+        setTotalCount(response.totalCount || 0);
+        setPage(response.next || "");
       } catch (e) {
         setDoFetch(false);
-        setError(e);
+        setError(e as Error);
       }
     }
 
@@ -70,7 +70,7 @@ export const useChannelMembers = (options: GetChannelMembersParameters): HookRet
 
   useEffect(() => {
     const listener = {
-      objects: (event) => {
+      objects: (event: ObjectsEvent) => {
         const message = event.message;
         if (message.type !== "membership") return;
 
@@ -99,5 +99,5 @@ export const useChannelMembers = (options: GetChannelMembersParameters): HookRet
     };
   }, [pubnub, paginatedOptions.channel]);
 
-  return [members, fetchMoreMembers, resetHook, totalCount, error];
+  return [members, fetchMoreMembers, resetHook, totalCount, error as Error];
 };

packages/common/src/hooks/use-channels.ts

@@ -1,5 +1,5 @@
 import { useState, useEffect } from "react";
-import { GetAllMetadataParameters } from "pubnub";
+import { GetAllMetadataParameters, ObjectsEvent } from "pubnub";
 import { usePubNub } from "pubnub-react";
 import { merge, cloneDeep } from "lodash";
 import { ChannelEntity } from "../types";
@@ -10,7 +10,7 @@ export const useChannels = (options: GetAllMetadataParameters = {}): HookReturnV
   const pubnub = usePubNub();
 
   const [channels, setChannels] = useState<ChannelEntity[]>([]);
-  const [page, setPage] = useState("");
+  const [page, setPage] = useState<string | undefined>("");
   const [totalCount, setTotalCount] = useState(0);
   const [error, setError] = useState<Error>();
   const [doFetch, setDoFetch] = useState(true);
@@ -35,11 +35,11 @@ export const useChannels = (options: GetAllMetadataParameters = {}): HookReturnV
         if (ignoreRequest) return;
         setDoFetch(false);
         setChannels((channels) => [...channels, ...response.data]);
-        setTotalCount(response.totalCount);
+        setTotalCount(response.totalCount || 0);
         setPage(response.next);
       } catch (e) {
         setDoFetch(false);
-        setError(e);
+        setError(e as Error);
       }
     }
 
@@ -50,7 +50,7 @@ export const useChannels = (options: GetAllMetadataParameters = {}): HookReturnV
 
   useEffect(() => {
     const listener = {
-      objects: (event) => {
+      objects: (event: ObjectsEvent) => {
         const message = event.message;
         if (message.type !== "channel") return;
 
@@ -79,5 +79,5 @@ export const useChannels = (options: GetAllMetadataParameters = {}): HookReturnV
     };
   }, [pubnub]);
 
-  return [channels, fetchMoreChannels, totalCount, error];
+  return [channels, fetchMoreChannels, totalCount, error as Error];
 };

packages/common/src/hooks/use-messages.ts

@@ -1,3 +1,6 @@
+// This file is unused so there is no need to keep it ts-checked
+// eslint-disable-next-line @typescript-eslint/ban-ts-comment
+// @ts-nocheck
 import { useState, useEffect, useRef } from "react";
 import { FetchMessagesParameters, MessageActionEvent, MessageEvent } from "pubnub";
 import { usePubNub } from "pubnub-react";

packages/common/src/hooks/use-presence.ts

@@ -1,5 +1,5 @@
 import { useState, useEffect } from "react";
-import { HereNowParameters, HereNowResponse } from "pubnub";
+import { HereNowParameters, HereNowResponse, PresenceEvent } from "pubnub";
 import { usePubNub } from "pubnub-react";
 import { cloneDeep } from "lodash";
 
@@ -39,7 +39,7 @@ export const usePresence = (options: HereNowParameters = {}): HookReturnValue =>
         setPresence(response.channels);
       } catch (e) {
         setDoFetch(false);
-        setError(e);
+        setError(e as Error);
       }
     }
 
@@ -50,7 +50,7 @@ export const usePresence = (options: HereNowParameters = {}): HookReturnValue =>
 
   useEffect(() => {
     const listener = {
-      presence: (event) => {
+      presence: (event: PresenceEvent) => {
         setPresence((presence) => {
           const presenceClone = cloneDeep(presence);
           if (!presenceClone[event.channel])
@@ -97,5 +97,5 @@ export const usePresence = (options: HereNowParameters = {}): HookReturnValue =>
     };
   }, [pubnub, options.includeUUIDs]);
 
-  return [presence, resetHook, total, error];
+  return [presence, resetHook, total, error as Error];
 };

packages/common/src/hooks/use-subscribe.ts

@@ -17,10 +17,14 @@ export const useSubscribe = (options: SubscribeParameters = {}): (() => void) =>
     const currentGroups = pubnub.getSubscribedChannelGroups() || [];
 
     const subscribeChannels = options.channels.filter((c) => !currentSubscriptions.includes(c));
-    const unsubscribeChannels = currentSubscriptions.filter((c) => !options.channels.includes(c));
+    const unsubscribeChannels = currentSubscriptions.filter(
+      (c) => !(options.channels as string[]).includes(c)
+    );
 
     const subscribeGroups = options.channelGroups.filter((c) => !currentGroups.includes(c));
-    const unsubscribeGroups = currentGroups.filter((c) => !options.channelGroups.includes(c));
+    const unsubscribeGroups = currentGroups.filter(
+      (c) => !(options.channelGroups as string[]).includes(c)
+    );
 
     if (subscribeChannels.length || subscribeGroups.length) {
       pubnub.subscribe({

packages/common/src/hooks/use-user-memberships.ts

@@ -1,18 +1,18 @@
 import { useState, useEffect, useMemo } from "react";
-import { GetMembershipsParametersv2 } from "pubnub";
+import { GetMembershipsParametersv2, ObjectsEvent } from "pubnub";
 import { usePubNub } from "pubnub-react";
 import { merge, cloneDeep } from "lodash";
 import { ChannelEntity } from "../types";
 
-type HookReturnValue = [ChannelEntity[], () => void, () => void, number, Error];
+type HookReturnValue = [ChannelEntity[], () => void, () => void, number | undefined, Error];
 
 export const useUserMemberships = (options: GetMembershipsParametersv2 = {}): HookReturnValue => {
   const jsonOptions = JSON.stringify(options);
 
   const pubnub = usePubNub();
   const [channels, setChannels] = useState<ChannelEntity[]>([]);
-  const [totalCount, setTotalCount] = useState(0);
-  const [page, setPage] = useState("");
+  const [totalCount, setTotalCount] = useState<number | undefined>(0);
+  const [page, setPage] = useState<string | undefined>("");
   const [error, setError] = useState<Error>();
   const [doFetch, setDoFetch] = useState(true);
 
@@ -59,7 +59,7 @@ export const useUserMemberships = (options: GetMembershipsParametersv2 = {}): Ho
         setPage(response.next);
       } catch (e) {
         setDoFetch(false);
-        setError(e);
+        setError(e as Error);
       }
     }
 
@@ -70,7 +70,7 @@ export const useUserMemberships = (options: GetMembershipsParametersv2 = {}): Ho
 
   useEffect(() => {
     const listener = {
-      objects: (event) => {
+      objects: (event: ObjectsEvent) => {
         const message = event.message;
         if (message.type !== "membership") return;
 
@@ -100,5 +100,5 @@ export const useUserMemberships = (options: GetMembershipsParametersv2 = {}): Ho
     };
   }, [pubnub, paginatedOptions.uuid]);
 
-  return [channels, fetchMoreMemberships, resetHook, totalCount, error];
+  return [channels, fetchMoreMemberships, resetHook, totalCount, error as Error];
 };

packages/common/src/hooks/use-user.ts

@@ -1,14 +1,14 @@
 import { useState, useEffect } from "react";
-import { GetUUIDMetadataParameters } from "pubnub";
+import { GetUUIDMetadataParameters, ObjectsEvent } from "pubnub";
 import { usePubNub } from "pubnub-react";
 import { cloneDeep } from "lodash";
 import { UserEntity } from "../types";
 
-export const useUser = (options: GetUUIDMetadataParameters = {}): [UserEntity, Error] => {
+export const useUser = (options: GetUUIDMetadataParameters = {}): [UserEntity | null, Error] => {
   const jsonOptions = JSON.stringify(options);
 
   const pubnub = usePubNub();
-  const [user, setUser] = useState(null);
+  const [user, setUser] = useState<UserEntity | null>(null);
   const [error, setError] = useState<Error>();
   const [doFetch, setDoFetch] = useState(true);
 
@@ -34,7 +34,7 @@ export const useUser = (options: GetUUIDMetadataParameters = {}): [UserEntity, E
         setUser(response.data);
       } catch (e) {
         setDoFetch(false);
-        setError(e);
+        setError(e as Error);
       }
     }
 
@@ -45,14 +45,14 @@ export const useUser = (options: GetUUIDMetadataParameters = {}): [UserEntity, E
 
   useEffect(() => {
     const listener = {
-      objects: (event) => {
+      objects: (event: ObjectsEvent) => {
         const message = event.message;
         if (message.type !== "uuid") return;
 
         setUser((user) => {
           const userCopy = cloneDeep(user);
 
-          if (message.data.id == user.id) {
+          if (message.data.id == userCopy?.id) {
             Object.assign(userCopy, message.data);
           }
 
@@ -68,5 +68,5 @@ export const useUser = (options: GetUUIDMetadataParameters = {}): [UserEntity, E
     };
   }, [pubnub]);
 
-  return [user, error];
+  return [user, error as Error];
 };

packages/common/src/hooks/use-users.ts

@@ -1,5 +1,5 @@
 import { useState, useEffect } from "react";
-import { GetAllMetadataParameters } from "pubnub";
+import { GetAllMetadataParameters, ObjectsEvent } from "pubnub";
 import { usePubNub } from "pubnub-react";
 import { merge, cloneDeep } from "lodash";
 import { UserEntity } from "../types";
@@ -35,11 +35,11 @@ export const useUsers = (options: GetAllMetadataParameters = {}): HookReturnValu
         if (ignoreRequest) return;
         setDoFetch(false);
         setUsers((users) => [...users, ...response.data]);
-        setTotalCount(response.totalCount);
-        setPage(response.next);
+        setTotalCount(response.totalCount || 0);
+        setPage(response.next || "");
       } catch (e) {
         setDoFetch(false);
-        setError(e);
+        setError(e as Error);
       }
     }
 
@@ -50,7 +50,7 @@ export const useUsers = (options: GetAllMetadataParameters = {}): HookReturnValu
 
   useEffect(() => {
     const listener = {
-      objects: (event) => {
+      objects: (event: ObjectsEvent) => {
         const message = event.message;
         if (message.type !== "uuid") return;
 
@@ -79,5 +79,5 @@ export const useUsers = (options: GetAllMetadataParameters = {}): HookReturnValu
     };
   }, [pubnub]);
 
-  return [users, fetchMoreUsers, totalCount, error];
+  return [users, fetchMoreUsers, totalCount, error as Error];
 };

packages/common/src/member-list/member-list.tsx

@@ -46,7 +46,7 @@ export const useMemberListCore = (props: CommonMemberListProps) => {
     return props.presentMembers?.includes(uuid);
   };
 
-  const memberSorter = (a, b) => {
+  const memberSorter = (a: UserEntity, b: UserEntity) => {
     if (props.sort) return props.sort(a, b);
 
     if (isOwnMember(a.id)) return -1;
@@ -55,7 +55,7 @@ export const useMemberListCore = (props: CommonMemberListProps) => {
     if (isPresentMember(a.id) && !isPresentMember(b.id)) return -1;
     if (isPresentMember(b.id) && !isPresentMember(a.id)) return 1;
 
-    return a.name.localeCompare(b.name, "en", { sensitivity: "base" });
+    return a.name?.localeCompare(b.name as string, "en", { sensitivity: "base" });
   };
 
   const memberFromString = (member: UserEntity | string) => {